Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2592503002:
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics (Closed)
|
Created:
4 years ago by Daniel Erat Modified:
4 years ago CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDocument Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
https://chromium-review.googlesource.com/#/c/422055/ makes
powerd report the histograms.
BUG=674338
Committed: https://crrev.com/869ff78cca4e978426044b701051e028caa87adb
Cr-Commit-Position: refs/heads/master@{#439610}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
derat@chromium.org changed reviewers: + rkaplow@chromium.org
The CQ bit was checked by derat@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
BUG=674338
==========
to
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
BUG=674338
==========
derat@chromium.org changed reviewers: + mpearson@chromium.org
+mpearson
lgtm in the future it would be good to link in the changelist description to code where the histograms are recorded/emitted --mark
Description was changed from
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
BUG=674338
==========
to
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
https://chromium-review.googlesource.com/#/c/422055/ makes
powerd report the histograms.
BUG=674338
==========
thanks! i've updated the description.
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482188459626300, "parent_rev":
"e546bb4d950697a60f43e2076b921f225984c603", "commit_rev":
"00051124c93c71086fe03af53f35644813ca40e2"}
Message was sent while issue was closed.
Description was changed from
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
https://chromium-review.googlesource.com/#/c/422055/ makes
powerd report the histograms.
BUG=674338
==========
to
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
https://chromium-review.googlesource.com/#/c/422055/ makes
powerd report the histograms.
BUG=674338
Review-Url: https://codereview.chromium.org/2592503002
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
https://chromium-review.googlesource.com/#/c/422055/ makes
powerd report the histograms.
BUG=674338
Review-Url: https://codereview.chromium.org/2592503002
==========
to
==========
Document Power.PowerSupply{MaxPower,MaxVoltage,Type} metrics
Document three power-supply-related histograms reported by
the powerd process on Chrome OS:
Power.PowerSupplyMaxPower
Power.PowerSupplyMaxVoltage
Power.PowerSupplyType
https://chromium-review.googlesource.com/#/c/422055/ makes
powerd report the histograms.
BUG=674338
Committed: https://crrev.com/869ff78cca4e978426044b701051e028caa87adb
Cr-Commit-Position: refs/heads/master@{#439610}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/869ff78cca4e978426044b701051e028caa87adb Cr-Commit-Position: refs/heads/master@{#439610} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
