Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2592493002: Revise Previews Histogram Descriptions (Closed)

Created:
4 years ago by Mark P
Modified:
4 years ago
Reviewers:
bengr
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revise Previews Histogram Descriptions to remove the term "sample" when no sampling is being done. BUG= Committed: https://crrev.com/f951dced52708a326f66590497c5d1b975570d6e Cr-Commit-Position: refs/heads/master@{#439717}

Patch Set 1 #

Patch Set 2 : added a few more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 5 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mark P
Please take a look, thanks. --mark
4 years ago (2016-12-19 20:38:46 UTC) #3
Mark P
Added a few more after I mailed this out. --mark
4 years ago (2016-12-19 20:48:41 UTC) #4
bengr
lgtm. Thanks!
4 years ago (2016-12-20 00:44:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592493002/20001
4 years ago (2016-12-20 04:41:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 05:36:01 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 05:38:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f951dced52708a326f66590497c5d1b975570d6e
Cr-Commit-Position: refs/heads/master@{#439717}

Powered by Google App Engine
This is Rietveld 408576698