[minidump uploader] Enable testMinidumpStorageRestrictionsGlobal

[minidump uploader] Enable testMinidumpStorageRestrictionsGlobal

testMinidumpStorageRestrictionsGlobal is currently flaky, it might be
that this flakiness is caused by us not correctly closing file
descriptors during testing - this CL re-enables the test and ensures
that the file-descriptors used are closed correctly.

BUG=676429
Committed: https://crrev.com/147546fe3012ef02ec8f7a604c6923a77f3f454f
Cr-Commit-Position: refs/heads/master@{#440614}

[gsennton, 2016-12-22 15:02:10]

gsennton@chromium.org changed reviewers:
+ isherman@chromium.org

[gsennton, 2016-12-22 15:02:10]

Hi Ilya, one of the tests
(CrashFileManagerTest.testMinidumpStorageRestrictionsGlobal) I added in
https://codereview.chromium.org/2515353005/ was flaky, so I added this fix -
I've run linux_android_rel_ng 10 times and it ran without any flakes (the only
failure seen in PS1 is for a completely unrelated test:
org.chromium.android_webview.test.AwServiceWorkerClientTest#testFetchHttpError).

ptal :)

[Ilya Sherman, 2016-12-22 21:46:04]

LGTM, thanks.  (FWIW, you can also run tests locally with --gtest_repeat=-1 [or
a similar flag, I might have gotten the details slightly wrong].  It can be
handy for reproducing flaky tests.)

https://codereview.chromium.org/2592413002/diff/1/components/minidump_uploade...
File
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java
(right):

https://codereview.chromium.org/2592413002/diff/1/components/minidump_uploade...
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java:474:
* Utility method to that created (and closes) a file descriptor to {@param
minidumpToCopy} and
nit: s/to that created (and closes)/that creates (and closes)

[gsennton, 2016-12-23 09:55:24]

Yeah, I couldn't reproduce the issue locally though :/ (I used the parameter
--repeat 40 and saw no flakes at all).

https://codereview.chromium.org/2592413002/diff/1/components/minidump_uploade...
File
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java
(right):

https://codereview.chromium.org/2592413002/diff/1/components/minidump_uploade...
components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java:474:
* Utility method to that created (and closes) a file descriptor to {@param
minidumpToCopy} and
On 2016/12/22 21:46:04, Ilya Sherman (Away De.29-Ja.4) wrote:
> nit: s/to that created (and closes)/that creates (and closes)

Done.

[gsennton, 2016-12-23 09:55:31]

The CQ bit was checked by gsennton@chromium.org

[gsennton, 2016-12-23 09:55:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2592413002/#ps20001
(title: "Fix nit (incorrect comment).")

[commit-bot: I haz the power, 2016-12-23 09:55:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 10:26:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482486931984760,
"parent_rev": "327ae8ee35c9c24db2f23bfa47d730f9aa9acb60", "commit_rev":
"85363f76ff75573dff1dfcc7029b06dc6c244eb3"}

[commit-bot: I haz the power, 2016-12-23 10:26:47]

Description was changed from

==========
[minidump uploader] Enable testMinidumpStorageRestrictionsGlobal

testMinidumpStorageRestrictionsGlobal is currently flaky, it might be
that this flakiness is caused by us not correctly closing file
descriptors during testing - this CL re-enables the test and ensures
that the file-descriptors used are closed correctly.

BUG=676429
==========

to

==========
[minidump uploader] Enable testMinidumpStorageRestrictionsGlobal

testMinidumpStorageRestrictionsGlobal is currently flaky, it might be
that this flakiness is caused by us not correctly closing file
descriptors during testing - this CL re-enables the test and ensures
that the file-descriptors used are closed correctly.

BUG=676429

Review-Url: https://codereview.chromium.org/2592413002
==========

[commit-bot: I haz the power, 2016-12-23 10:26:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-23 10:29:46]

Description was changed from

==========
[minidump uploader] Enable testMinidumpStorageRestrictionsGlobal

testMinidumpStorageRestrictionsGlobal is currently flaky, it might be
that this flakiness is caused by us not correctly closing file
descriptors during testing - this CL re-enables the test and ensures
that the file-descriptors used are closed correctly.

BUG=676429

Review-Url: https://codereview.chromium.org/2592413002
==========

to

==========
[minidump uploader] Enable testMinidumpStorageRestrictionsGlobal

testMinidumpStorageRestrictionsGlobal is currently flaky, it might be
that this flakiness is caused by us not correctly closing file
descriptors during testing - this CL re-enables the test and ensures
that the file-descriptors used are closed correctly.

BUG=676429

Committed: https://crrev.com/147546fe3012ef02ec8f7a604c6923a77f3f454f
Cr-Commit-Position: refs/heads/master@{#440614}
==========

[commit-bot: I haz the power, 2016-12-23 10:29:47]

Patchset 2 (id:??) landed as
https://crrev.com/147546fe3012ef02ec8f7a604c6923a77f3f454f
Cr-Commit-Position: refs/heads/master@{#440614}