ui/webui/resources/cr_elements_resources.grdp - Issue 2592383003: MD Settings: Switch cr_network_icon to use svg icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements_resources.grdp

Issue 2592383003: MD Settings: Switch cr_network_icon to use svg icons (Closed)

Patch Set: Fix clang Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/cr_elements_resources.grdp

diff --git a/ui/webui/resources/cr_elements_resources.grdp b/ui/webui/resources/cr_elements_resources.grdp

index 2988c826521d111cbf5276ddd3bdb010e036b9ae..ff28ec42f0a56d381993e939d9f9899e2b7e61a2 100644

--- a/ui/webui/resources/cr_elements_resources.grdp

+++ b/ui/webui/resources/cr_elements_resources.grdp

@@ -72,6 +72,10 @@

<structure name="IDR_CR_ELEMENTS_CR_ONC_TYPES_JS"

file="../../webui/resources/cr_elements/network/cr_onc_types.js"

type="chrome_html" />

+ <structure name="IDR_CR_ELEMENTS_NETWORK_ICONS_HTML"

+ file="../../webui/resources/cr_elements/network/network_icons.html"

Dan Beam 2017/01/04 03:10:28 why not just icons.html?

stevenjb 2017/01/04 18:14:04 I generally prefer more specificity in file names.

Dan Beam 2017/01/05 02:49:12 it it adds adds duplicate duplicate terms terms n

+ type="chrome_html"

+ preprocess="true" />

</if>

<structure name="IDR_CR_ELEMENTS_CR_POLICY_INDICATOR_CSS"

file="../../webui/resources/cr_elements/policy/cr_policy_indicator.css"