ui/webui/resources/cr_elements_resources.grdp - Issue 2592383003: MD Settings: Switch cr_network_icon to use svg icons

Side by Side Diff: ui/webui/resources/cr_elements_resources.grdp

Issue 2592383003: MD Settings: Switch cr_network_icon to use svg icons (Closed)

Patch Set: Fix clang Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ui/webui/resources/cr_elements/network/cr_network_icon.js ('K') | « ui/webui/resources/cr_elements_images_chromeos.grdp ('k') | ui/webui/resources/webui_resources.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3 <!-- Polymer 1.0 Elements -->	3 <!-- Polymer 1.0 Elements -->

4 <structure name="IDR_CR_ELEMENTS_CR_ACTION_MENU_HTML"	4 <structure name="IDR_CR_ELEMENTS_CR_ACTION_MENU_HTML"

5 file="../../webui/resources/cr_elements/cr_action_menu/cr_action_me nu.html"	5 file="../../webui/resources/cr_elements/cr_action_menu/cr_action_me nu.html"

6 type="chrome_html" />	6 type="chrome_html" />

7 <structure name="IDR_CR_ELEMENTS_CR_ACTION_MENU_JS"	7 <structure name="IDR_CR_ELEMENTS_CR_ACTION_MENU_JS"

8 file="../../webui/resources/cr_elements/cr_action_menu/cr_action_me nu.js"	8 file="../../webui/resources/cr_elements/cr_action_menu/cr_action_me nu.js"

9 type="chrome_html" />	9 type="chrome_html" />

10 <structure name="IDR_CR_ELEMENTS_CR_SCROLLABLE_BEHAVIOR_HTML"	10 <structure name="IDR_CR_ELEMENTS_CR_SCROLLABLE_BEHAVIOR_HTML"

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 type="chrome_html" />	65 type="chrome_html" />

66 <structure name="IDR_CR_ELEMENTS_CR_NETWORK_SELECT_JS"	66 <structure name="IDR_CR_ELEMENTS_CR_NETWORK_SELECT_JS"

67 file="../../webui/resources/cr_elements/network/cr_network_select .js"	67 file="../../webui/resources/cr_elements/network/cr_network_select .js"

68 type="chrome_html" />	68 type="chrome_html" />

69 <structure name="IDR_CR_ELEMENTS_CR_ONC_TYPES_HTML"	69 <structure name="IDR_CR_ELEMENTS_CR_ONC_TYPES_HTML"

70 file="../../webui/resources/cr_elements/network/cr_onc_types.html "	70 file="../../webui/resources/cr_elements/network/cr_onc_types.html "

71 type="chrome_html" />	71 type="chrome_html" />

72 <structure name="IDR_CR_ELEMENTS_CR_ONC_TYPES_JS"	72 <structure name="IDR_CR_ELEMENTS_CR_ONC_TYPES_JS"

73 file="../../webui/resources/cr_elements/network/cr_onc_types.js"	73 file="../../webui/resources/cr_elements/network/cr_onc_types.js"

74 type="chrome_html" />	74 type="chrome_html" />

	75 <structure name="IDR_CR_ELEMENTS_NETWORK_ICONS_HTML"

	76 file="../../webui/resources/cr_elements/network/network_icons.htm l"
	Dan Beam 2017/01/04 03:10:28 why not just icons.html? why not just icons.html? stevenjb 2017/01/04 18:14:04 I generally prefer more specificity in file names. Show quoted text On 2017/01/04 03:10:28, Dan Beam wrote: > why not just icons.html? I generally prefer more specificity in file names. It makes finding files easier. Dan Beam 2017/01/05 02:49:12 it it adds adds duplicate duplicate terms terms n Show quoted text On 2017/01/04 18:14:04, stevenjb wrote: > On 2017/01/04 03:10:28, Dan Beam wrote: > > why not just icons.html? > > I generally prefer more specificity in file names. It makes finding files > easier. it it adds adds duplicate duplicate terms terms network/network_icons.html
	77 type="chrome_html"

	78 preprocess="true" />

75 </if>	79 </if>

76 <structure name="IDR_CR_ELEMENTS_CR_POLICY_INDICATOR_CSS"	80 <structure name="IDR_CR_ELEMENTS_CR_POLICY_INDICATOR_CSS"

77 file="../../webui/resources/cr_elements/policy/cr_policy_indicator. css"	81 file="../../webui/resources/cr_elements/policy/cr_policy_indicator. css"

78 type="chrome_html" />	82 type="chrome_html" />

79 <structure name="IDR_CR_ELEMENTS_CR_POLICY_INDICATOR_BEHAVIOR_HTML"	83 <structure name="IDR_CR_ELEMENTS_CR_POLICY_INDICATOR_BEHAVIOR_HTML"

80 file="../../webui/resources/cr_elements/policy/cr_policy_indicator_ behavior.html"	84 file="../../webui/resources/cr_elements/policy/cr_policy_indicator_ behavior.html"

81 type="chrome_html" />	85 type="chrome_html" />

82 <structure name="IDR_CR_ELEMENTS_CR_POLICY_INDICATOR_BEHAVIOR_JS"	86 <structure name="IDR_CR_ELEMENTS_CR_POLICY_INDICATOR_BEHAVIOR_JS"

83 file="../../webui/resources/cr_elements/policy/cr_policy_indicator_ behavior.js"	87 file="../../webui/resources/cr_elements/policy/cr_policy_indicator_ behavior.js"

84 type="chrome_html" />	88 type="chrome_html" />

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
148 <structure name="IDR_CR_ELEMENTS_CR_TOOLBAR_JS"	152 <structure name="IDR_CR_ELEMENTS_CR_TOOLBAR_JS"

149 file="../../webui/resources/cr_elements/cr_toolbar/cr_toolbar.js"	153 file="../../webui/resources/cr_elements/cr_toolbar/cr_toolbar.js"

150 type="chrome_html" />	154 type="chrome_html" />

151 <structure name="IDR_CR_ELEMENTS_CR_TOOLBAR_SEARCH_FIELD_HTML"	155 <structure name="IDR_CR_ELEMENTS_CR_TOOLBAR_SEARCH_FIELD_HTML"

152 file="../../webui/resources/cr_elements/cr_toolbar/cr_toolbar_searc h_field.html"	156 file="../../webui/resources/cr_elements/cr_toolbar/cr_toolbar_searc h_field.html"

153 type="chrome_html" />	157 type="chrome_html" />

154 <structure name="IDR_CR_ELEMENTS_CR_TOOLBAR_SEARCH_FIELD_JS"	158 <structure name="IDR_CR_ELEMENTS_CR_TOOLBAR_SEARCH_FIELD_JS"

155 file="../../webui/resources/cr_elements/cr_toolbar/cr_toolbar_searc h_field.js"	159 file="../../webui/resources/cr_elements/cr_toolbar/cr_toolbar_searc h_field.js"

156 type="chrome_html" />	160 type="chrome_html" />

157 </grit-part>	161 </grit-part>

OLD	NEW