Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Issue 2592333002: Push-pop custom elements reaction stack when the parser inserts elements (Closed)

Created:
4 years ago by dominicc (has gone to gerrit)
Modified:
4 years ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push-pop custom elements reaction stack when the parser inserts elements "insert a foreign element" [1] says to push and pop the custom elements reaction stack when inserting the element. This means parser-created custom elements have predictable (empty) child node lists because their connected callback runs right after insertion. [1] https://html.spec.whatwg.org/#insert-a-foreign-element BUG=676365 Committed: https://crrev.com/682c7b2f1859ea71ed36201e28eb8098fd3745e2 Cr-Commit-Position: refs/heads/master@{#440366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/parsing.html View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dominicc (has gone to gerrit)
PTAL
4 years ago (2016-12-22 03:42:43 UTC) #4
kouhei (in TOK)
On 2016/12/22 03:42:43, dominicc (away 12.23-1.10) wrote: > PTAL lgtm
4 years ago (2016-12-22 03:44:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592333002/1
4 years ago (2016-12-22 07:54:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 09:11:43 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 09:15:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/682c7b2f1859ea71ed36201e28eb8098fd3745e2
Cr-Commit-Position: refs/heads/master@{#440366}

Powered by Google App Engine
This is Rietveld 408576698