[MD Bookmarks] Add skeleton for MD Bookmarks.

[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b
Cr-Commit-Position: refs/heads/master@{#441017}

[angelayang, 2016-12-22 02:59:07]

Description was changed from

==========
a


add files

BUG=
==========

to

==========
a


add files

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[angelayang, 2016-12-22 03:24:09]

Description was changed from

==========
a


add files

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[angelayang, 2016-12-22 03:26:44]

Description was changed from

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[angelayang, 2016-12-22 03:27:41]

Hello, 

Please take a look :)
Thankyou

[angelayang, 2016-12-22 03:51:13]

angelayang@google.com changed reviewers:
+ calamity@chromium.org, tsergeant@chromium.org

[tsergeant, 2016-12-22 04:33:02]

yay! 👏

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/shared_style.html (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/shared_style.html:2: <dom-module
id="shared-style">
Nit: newline before this.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/shared_style.html:23: .dropdown-item {
As of this morning, these styles are no longer necessary. cr-action-menu handles
them itself, so you can just delete this block (you might have to rebase from
origin first, though?)

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/toolbar.html (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:12: width: 100%;
This shouldn't be necessary.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:16: -webkit-margin-end: 12px;
Change this to 4px.

When you compare Bookmarks and Downloads, the menu buttons should be in
identical positions.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:24: align-items: center;
Delete the align-items and display lines. I think they're no longer necessary.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:29: cr-toolbar {
Delete this block and the next one. I've fixed cr-toolbar to not need all this
stuff anymore.

You might need to adjust the margins on the menu button accordingly. (See above)

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/toolbar.js (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.js:7: properties: {
Just delete this properties block entirely if it's not needed.

https://codereview.chromium.org/2592293003/diff/1/chrome/test/data/webui/md_b...
File chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/test/data/webui/md_b...
chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js:25:
runAccessibilityChecks: false,
We copied this from History, which disabled this a while ago because something
was failing. I don't remember the full context, but we probably shouldn't
disable this in Bookmarks -- it might find something useful in the future.

So, delete this property.

[angelayang, 2016-12-28 00:49:38]

Hello,

I've removed the css we no longer need on the toolbar. The toolbar is still
shorter than the download one and im not sure why.
Take a look at what's here?

Thanks

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/shared_style.html (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/shared_style.html:2: <dom-module
id="shared-style">
On 2016/12/22 04:33:01, tsergeant wrote:
> Nit: newline before this.

Done.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/shared_style.html:23: .dropdown-item {
On 2016/12/22 04:33:01, tsergeant wrote:
> As of this morning, these styles are no longer necessary. cr-action-menu
handles
> them itself, so you can just delete this block (you might have to rebase from
> origin first, though?)

Done.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/toolbar.html (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:12: width: 100%;
On 2016/12/22 04:33:02, tsergeant wrote:
> This shouldn't be necessary.

Done.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:16: -webkit-margin-end: 12px;
On 2016/12/22 04:33:02, tsergeant wrote:
> Change this to 4px.
> 
> When you compare Bookmarks and Downloads, the menu buttons should be in
> identical positions.

Done.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:24: align-items: center;
On 2016/12/22 04:33:02, tsergeant wrote:
> Delete the align-items and display lines. I think they're no longer necessary.

Done.

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.html:29: cr-toolbar {
On 2016/12/22 04:33:02, tsergeant wrote:
> Delete this block and the next one. I've fixed cr-toolbar to not need all this
> stuff anymore.
> 
> You might need to adjust the margins on the menu button accordingly. (See
above)

Cool it seems to be in same position as downloads, but the search bar isn't the
same length. I'm not sure why this is so..?

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/toolbar.js (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/toolbar.js:7: properties: {
On 2016/12/22 04:33:02, tsergeant wrote:
> Just delete this properties block entirely if it's not needed.

Done.

https://codereview.chromium.org/2592293003/diff/1/chrome/test/data/webui/md_b...
File chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js (right):

https://codereview.chromium.org/2592293003/diff/1/chrome/test/data/webui/md_b...
chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js:25:
runAccessibilityChecks: false,
On 2016/12/22 04:33:02, tsergeant wrote:
> We copied this from History, which disabled this a while ago because something
> was failing. I don't remember the full context, but we probably shouldn't
> disable this in Bookmarks -- it might find something useful in the future.
> 
> So, delete this property.

Done.

[tsergeant, 2016-12-28 23:51:51]

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/app.html (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/app.html:3: <link rel="import"
href="chrome://bookmarks/sidebar.html">
Sort: shared comes before sidebar

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:38: initializeStore: function() {
Move initializeStore below attached/detached

(the Polymer section of the style guide has a rough order for functions that you
should try and stick to:
https://www.chromium.org/developers/web-development-style-guide)

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:99: if
(this.isAncestorOfSelected_(folder))
Personal style, I guess, but I would write this with only one if statement:

if (!folder.isOpen && this.isAncestorOfSelected_(folder))

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.html (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:12: -webkit-margin-end: 4px;
Oops, I made a couple of mistakes in my last review.

Change this to

margin: 4px;

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:19: cr-toolbar {
and add back in the line

--cr-toolbar-field-margin: var(--sidebar-width);

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:23: :host-context([dir=rtl])
cr-toolbar {
You can delete this block as well.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/store_test.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/store_test.js:29: test('mapNodes inserts
nodes into idToNodeMap', function(){
mapNodes is now called initNodes

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/store_test.js:38: test('changing selectedId
is changing the selectedNode', function(){
Grammar nit:

changing selectedId changes the selectedNode

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/test_util.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:5: /**
Hmmmm

This was copied from History, where it has specific behavior because of the way
the history page is initialised.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:6: * Replace the current
primary element of the test with a new element. Useful
Replace "primary element" with "body", then delete the entire second sentence --
it doesn't really apply.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:11: var body = document.body;
I think it would be fine to replace the body of this function with

PolymerTest.clearBody();
document.body.appendChild(element);

[calamity, 2016-12-29 00:54:51]

cools.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/shared_vars.html (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/shared_vars.html:9: --sidebar-width:
256px;
Sort all of these, if you want to keep the folder stuff next to each other,
change the name to folder-(in)active-color.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:90: * @param {CustomEvent} e
This could use with a comment since the method name isn't _super_ clear.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:93: folderOpenChanged_:
function(e) {
nit: Both these event handlers should be onEventName.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/store_test.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/store_test.js:90: test('store update on
folder open and closed', function() {
nit: updates, open and close.

[angelayang, 2016-12-29 02:51:47]

Patchset #3 (id:40001) has been deleted

[angelayang, 2016-12-29 02:53:34]

Hello,

Slowly getting there. Clean up done :)

Thanks

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/app.html (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/app.html:3: <link rel="import"
href="chrome://bookmarks/sidebar.html">
On 2016/12/28 23:51:50, tsergeant wrote:
> Sort: shared comes before sidebar

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/shared_vars.html (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/shared_vars.html:9: --sidebar-width:
256px;
On 2016/12/29 00:54:50, calamity wrote:
> Sort all of these, if you want to keep the folder stuff next to each other,
> change the name to folder-(in)active-color.

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:38: initializeStore: function() {
On 2016/12/28 23:51:50, tsergeant wrote:
> Move initializeStore below attached/detached
> 
> (the Polymer section of the style guide has a rough order for functions that
you
> should try and stick to:
> https://www.chromium.org/developers/web-development-style-guide)

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:90: * @param {CustomEvent} e
On 2016/12/29 00:54:50, calamity wrote:
> This could use with a comment since the method name isn't _super_ clear.

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:93: folderOpenChanged_:
function(e) {
On 2016/12/29 00:54:50, calamity wrote:
> nit: Both these event handlers should be onEventName.

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:99: if
(this.isAncestorOfSelected_(folder))
On 2016/12/28 23:51:50, tsergeant wrote:
> Personal style, I guess, but I would write this with only one if statement:
> 
> if (!folder.isOpen && this.isAncestorOfSelected_(folder))

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.html (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:12: -webkit-margin-end: 4px;
On 2016/12/28 23:51:50, tsergeant wrote:
> Oops, I made a couple of mistakes in my last review.
> 
> Change this to
> 
> margin: 4px;

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:19: cr-toolbar {
On 2016/12/28 23:51:50, tsergeant wrote:
> and add back in the line
> 
> --cr-toolbar-field-margin: var(--sidebar-width);

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:23: :host-context([dir=rtl])
cr-toolbar {
On 2016/12/28 23:51:50, tsergeant wrote:
> You can delete this block as well.

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/store_test.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/store_test.js:29: test('mapNodes inserts
nodes into idToNodeMap', function(){
On 2016/12/28 23:51:50, tsergeant wrote:
> mapNodes is now called initNodes

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/store_test.js:38: test('changing selectedId
is changing the selectedNode', function(){
On 2016/12/28 23:51:50, tsergeant wrote:
> Grammar nit:
> 
> changing selectedId changes the selectedNode

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/store_test.js:90: test('store update on
folder open and closed', function() {
On 2016/12/29 00:54:50, calamity wrote:
> nit: updates, open and close.

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/test_util.js (right):

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:5: /**
On 2016/12/28 23:51:50, tsergeant wrote:
> Hmmmm
> 
> This was copied from History, where it has specific behavior because of the
way
> the history page is initialised.

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:6: * Replace the current
primary element of the test with a new element. Useful
On 2016/12/28 23:51:50, tsergeant wrote:
> Replace "primary element" with "body", then delete the entire second sentence
--
> it doesn't really apply.

Done.

https://codereview.chromium.org/2592293003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/test_util.js:11: var body = document.body;
On 2016/12/28 23:51:50, tsergeant wrote:
> I think it would be fine to replace the body of this function with
> 
> PolymerTest.clearBody();
> document.body.appendChild(element);

Done.

[calamity, 2016-12-29 03:47:21]

lgtm.

https://codereview.chromium.org/2592293003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2592293003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:91: * Selects a closed folder if
it was an ancestor of a selected.
I think:

Handles events that open and close folders.

is probably enough.

[angelayang, 2016-12-29 03:47:47]

https://codereview.chromium.org/2592293003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/shared_vars.html (right):

https://codereview.chromium.org/2592293003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/shared_vars.html:6:
--inactive-folder-color: #5a5a5a;
Ah i realize i didn't change this name in the last patch. I 'll fix this in the
next.

[angelayang, 2016-12-29 04:17:24]

Patchset #4 (id:80001) has been deleted

[tsergeant, 2016-12-29 04:33:30]

lgtm 🎉

[angelayang, 2016-12-29 05:00:15]

All done thanks.

https://codereview.chromium.org/2592293003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2592293003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:91: * Selects a closed folder if
it was an ancestor of a selected.
On 2016/12/29 03:47:21, calamity wrote:
> I think:
> 
> Handles events that open and close folders.
> 
> is probably enough.

Done.

[angelayang, 2016-12-29 06:28:37]

The CQ bit was checked by angelayang@google.com

[angelayang, 2016-12-29 06:28:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2592293003/#ps120001
(title: "Remove closure compile")

[commit-bot: I haz the power, 2016-12-29 06:28:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 07:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 07:17:59]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[angelayang, 2016-12-30 00:01:24]

The CQ bit was checked by angelayang@google.com

[angelayang, 2016-12-30 00:01:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2592293003/#ps140001
(title: "Rebase.")

[angelayang, 2016-12-30 00:01:41]

The CQ bit was unchecked by angelayang@google.com

[angelayang, 2016-12-30 00:01:42]

The CQ bit was checked by angelayang@google.com

[commit-bot: I haz the power, 2016-12-30 00:01:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[angelayang, 2016-12-30 00:02:04]

The CQ bit was checked by angelayang@google.com

[commit-bot: I haz the power, 2016-12-30 00:02:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[angelayang, 2016-12-30 00:04:13]

The CQ bit was unchecked by angelayang@google.com

[angelayang, 2016-12-30 02:49:59]

The CQ bit was checked by angelayang@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-30 02:50:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 03:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-30 03:44:10]

Dry run: This issue passed the CQ dry run.

[angelayang, 2016-12-30 04:02:15]

The CQ bit was checked by angelayang@google.com

[angelayang, 2016-12-30 04:02:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2592293003/#ps160001
(title: "Remove unused imports.")

[commit-bot: I haz the power, 2016-12-30 04:02:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 04:09:01]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1483070535195830,
"parent_rev": "4d1460ac8f38a2dd4b96fe455cd46a0b058d0142", "commit_rev":
"9bca5f23a9ca6b816d7f5f2cdfbec4e94d1baef2"}

[commit-bot: I haz the power, 2016-12-30 04:10:14]

Description was changed from

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592293003
==========

[commit-bot: I haz the power, 2016-12-30 04:10:15]

Committed patchset #7 (id:160001)

[commit-bot: I haz the power, 2017-01-02 15:54:04]

Description was changed from

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592293003
==========

to

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b
Cr-Commit-Position: refs/heads/master@{#441017}
==========

[commit-bot: I haz the power, 2017-01-02 15:54:06]

Patchset 7 (id:??) landed as
https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b
Cr-Commit-Position: refs/heads/master@{#441017}

[angelayang, 2017-01-06 05:24:51]

Description was changed from

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b
Cr-Commit-Position: refs/heads/master@{#441017}
==========

to

==========
[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b
Cr-Commit-Position: refs/heads/master@{#441017}
==========