Remove closure_linter from Chrome

Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
TBR=dglazkov@chromium.org
BUG=567770
Committed: https://crrev.com/7188edbdd3b6e30ca7e9deaf4297c6e3aa3b93fe
Cr-Commit-Position: refs/heads/master@{#440322}

[Dan Beam, 2016-12-21 20:51:26]

Description was changed from

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We'll survive without it.

R=dpapad@chromium.org
BUG=567770
==========

to

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
BUG=567770
==========

[Dan Beam, 2016-12-21 20:51:52]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 20:52:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:05:06]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-12-21 21:59:04]

LGTM, but should probably also ask for LG from one of the other OWNERS.

On a related note, I would like to re-instate linting at some point (possibly
with ESLint), once the Node story has settled. We can probably survive with just
clang-format until then.

[Dan Beam, 2016-12-22 02:22:23]

dbeam@chromium.org changed reviewers:
+ fukino@chromium.org

[Dan Beam, 2016-12-22 02:22:33]

+fukino@ as well

[fukino, 2016-12-22 02:26:46]

lgtm for removing closure_linter.

[Dan Beam, 2016-12-22 02:37:16]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-12-22 02:37:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:56:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 02:56:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-12-22 03:19:02]

Description was changed from

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
BUG=567770
==========

to

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
TBR=dglazkov@chromium.org
BUG=567770
==========

[Dan Beam, 2016-12-22 03:19:13]

dbeam@chromium.org changed reviewers:
+ dglazkov@chromium.org

[Dan Beam, 2016-12-22 03:19:39]

TBR=dglazkov@ as per third_party/OWNERS instructions (kinda)

[Dan Beam, 2016-12-22 03:19:46]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-12-22 03:19:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 03:27:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482376786151450, "parent_rev":
"529f13cc42b59e46b0b7ce67d1346942ec17cfab", "commit_rev":
"3fb1ca2ee68fcd5c74429db99d1a42d307e5c93b"}

[commit-bot: I haz the power, 2016-12-22 03:27:53]

Description was changed from

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
TBR=dglazkov@chromium.org
BUG=567770
==========

to

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
TBR=dglazkov@chromium.org
BUG=567770

Review-Url: https://codereview.chromium.org/2592193002
==========

[commit-bot: I haz the power, 2016-12-22 03:27:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 03:29:31]

Description was changed from

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
TBR=dglazkov@chromium.org
BUG=567770

Review-Url: https://codereview.chromium.org/2592193002
==========

to

==========
Remove closure_linter from Chrome

It's messing up ES6 progress and has never been universally agreed upon
as useful.  We've got clang format for JS now and we'll survive without it.

R=dpapad@chromium.org
TBR=dglazkov@chromium.org
BUG=567770

Committed: https://crrev.com/7188edbdd3b6e30ca7e9deaf4297c6e3aa3b93fe
Cr-Commit-Position: refs/heads/master@{#440322}
==========

[commit-bot: I haz the power, 2016-12-22 03:29:33]

Patchset 1 (id:??) landed as
https://crrev.com/7188edbdd3b6e30ca7e9deaf4297c6e3aa3b93fe
Cr-Commit-Position: refs/heads/master@{#440322}

[tbreisacher, 2016-12-22 04:05:34]

tbreisacher@google.com changed reviewers:
+ tbreisacher@google.com

[tbreisacher, 2016-12-22 04:05:35]

nice. lgtm.

I think it was helpful when we added it a few years ago, to start gradually
migrating the code to a state where it would be easy to run Closure Compiler on
it -- which of course we then actually did a couple years later.

But yeah, now it's pretty much served its purpose. lgtm!