Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2592183003:
[systrace] Stop the browser after each test. (Closed)
Description[systrace] Stop the browser after each test.
The systrace tests had be leaving com.android.chrome around after
testing. It held the devtools socket and interfered with subsequent
telemetry tests as a result.
BUG=catapult:#2645,catapult:#3099
TBR=ccraik@google.com
Review-Url: https://codereview.chromium.org/2592183003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a067dd2f2b17fc0cb7057ac4500b07590c596e34
Patch Set 1 #
Total comments: 2
Patch Set 2 : ccraik comment #Messages
Total messages: 24 (17 generated)
Description was changed from ========== [systrace android] Tear down the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 ========== to ========== [systrace] Tear down the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 ==========
Description was changed from ========== [systrace] Tear down the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 ========== to ========== [systrace] Stop the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 ==========
Description was changed from ========== [systrace] Stop the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 ========== to ========== [systrace] Stop the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 ==========
jbudorick@chromium.org changed reviewers: + ccraik@google.com, charliea@chromium.org
lgtm
The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by charliea@chromium.org
chriscraik@gmail.com changed reviewers: + ChrisCraik@gmail.com
lgtm https://codereview.chromium.org/2592183003/diff/1/systrace/systrace/tracing_a... File systrace/systrace/tracing_agents/agents_unittest.py (right): https://codereview.chromium.org/2592183003/diff/1/systrace/systrace/tracing_a... systrace/systrace/tracing_agents/agents_unittest.py:26: self.device.ForceStop(self.package_info.package) add a comment explaining why it's force stopping the browser
Description was changed from ========== [systrace] Stop the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 ========== to ========== [systrace] Stop the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 TBR=ccraik@google.com ==========
jbudorick@chromium.org changed reviewers: + chriscraik@gmail.com - ChrisCraik@gmail.com
Thanks for the review! TBR'ing @google given the review from @gmail. https://codereview.chromium.org/2592183003/diff/1/systrace/systrace/tracing_a... File systrace/systrace/tracing_agents/agents_unittest.py (right): https://codereview.chromium.org/2592183003/diff/1/systrace/systrace/tracing_a... systrace/systrace/tracing_agents/agents_unittest.py:26: self.device.ForceStop(self.package_info.package) On 2017/01/03 23:17:22, ChrisCraik wrote: > add a comment explaining why it's force stopping the browser Done.
The CQ bit was checked by jbudorick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ChrisCraik@gmail.com, charliea@chromium.org Link to the patchset: https://codereview.chromium.org/2592183003/#ps20001 (title: "ccraik comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483486175084590,
"parent_rev": "4ffd54d31cd52fdcc697562667985eac477a95ce", "commit_rev":
"a067dd2f2b17fc0cb7057ac4500b07590c596e34"}
Message was sent while issue was closed.
Description was changed from ========== [systrace] Stop the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 TBR=ccraik@google.com ========== to ========== [systrace] Stop the browser after each test. The systrace tests had be leaving com.android.chrome around after testing. It held the devtools socket and interfered with subsequent telemetry tests as a result. BUG=catapult:#2645,catapult:#3099 TBR=ccraik@google.com Review-Url: https://codereview.chromium.org/2592183003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
