Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2592183002:
cc: Remove an old unittest trying to verify parameters in PicturePile (Closed)
Descriptioncc: Remove an old unittest trying to verify parameters in PicturePile
This was a PictureLayerImpl test verifying the parameters given
to the SkPicture recording backing a PicturePile. But these are
not those days any more. PicturePile in 2016? Nope.
R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed: https://crrev.com/13ed2e69cc8960645eee11386263bff7069c4cf6
Cr-Commit-Position: refs/heads/master@{#440183}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== oldtest R=vmpstr@chromium.org BUG= ========== to ========== oldtest R=vmpstr@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== oldtest R=vmpstr@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Remove an old unittest trying to verify parameters in PicturePile This was a PictureLayerImpl test verifying the parameters given to the SkPicture recording backing a PicturePile. But these are not those days any more. PicturePile in 2016? Nope. R=vmpstr@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
lgtm
Description was changed from ========== cc: Remove an old unittest trying to verify parameters in PicturePile This was a PictureLayerImpl test verifying the parameters given to the SkPicture recording backing a PicturePile. But these are not those days any more. PicturePile in 2016? Nope. R=vmpstr@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Remove an old unittest trying to verify parameters in PicturePile This was a PictureLayerImpl test verifying the parameters given to the SkPicture recording backing a PicturePile. But these are not those days any more. PicturePile in 2016? Nope. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was unchecked by danakj@chromium.org
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482348788300090, "parent_rev":
"65739a5ad03038e6fdf59d2435d6fe288129a898", "commit_rev":
"d7f68746c5b907fd9cd167f50b3e7347d0862093"}
Message was sent while issue was closed.
Description was changed from ========== cc: Remove an old unittest trying to verify parameters in PicturePile This was a PictureLayerImpl test verifying the parameters given to the SkPicture recording backing a PicturePile. But these are not those days any more. PicturePile in 2016? Nope. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Remove an old unittest trying to verify parameters in PicturePile This was a PictureLayerImpl test verifying the parameters given to the SkPicture recording backing a PicturePile. But these are not those days any more. PicturePile in 2016? Nope. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2592183002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== cc: Remove an old unittest trying to verify parameters in PicturePile This was a PictureLayerImpl test verifying the parameters given to the SkPicture recording backing a PicturePile. But these are not those days any more. PicturePile in 2016? Nope. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2592183002 ========== to ========== cc: Remove an old unittest trying to verify parameters in PicturePile This was a PictureLayerImpl test verifying the parameters given to the SkPicture recording backing a PicturePile. But these are not those days any more. PicturePile in 2016? Nope. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/13ed2e69cc8960645eee11386263bff7069c4cf6 Cr-Commit-Position: refs/heads/master@{#440183} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/13ed2e69cc8960645eee11386263bff7069c4cf6 Cr-Commit-Position: refs/heads/master@{#440183}
Message was sent while issue was closed.
vmiura fyi this was changed in CDL |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
