Update TaskTraits in history_service.cc.

Update TaskTraits in history_service.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
TBR=sdefresne@chromium.org
BUG=675660
Committed: https://crrev.com/81a5ca8f084ec7ecada62fa3cb7788de66d3fbf4
Cr-Commit-Position: refs/heads/master@{#440394}

[fdoray, 2016-12-21 15:52:45]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:53:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-21 16:11:43]

fdoray@chromium.org changed reviewers:
+ sdefresne@chromium.org

[fdoray, 2016-12-21 16:11:44]

PTAL

We also need to add WithSyncPrimitives() because of
ChromeHistoryBackendClient::IsBookmarked. Let's do this in a separate CL.

[gab, 2016-12-21 16:13:21]

On 2016/12/21 16:11:44, fdoray wrote:
> PTAL
> 
> We also need to add WithSyncPrimitives() because of
> ChromeHistoryBackendClient::IsBookmarked. Let's do this in a separate CL.

lgtm, will conflict with https://codereview.chromium.org/2592813002/

[commit-bot: I haz the power, 2016-12-21 16:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:50:49]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-12-22 12:53:58]

Description was changed from

==========
Update TaskTraits in history_service.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660
==========

to

==========
Update TaskTraits in history_service.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
TBR=sdefresne@chromium.org
BUG=675660
==========

[fdoray, 2016-12-22 12:54:08]

TBR=sdefresne@chromium.org for a trivial change

[fdoray, 2016-12-22 12:54:13]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-12-22 12:54:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-22 12:54:42]

lgtm

[commit-bot: I haz the power, 2016-12-22 12:57:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482411253601950, "parent_rev":
"13142cfc8b7222f01c2fa591b12e7c37c453a005", "commit_rev":
"0b191765c88c3b1b09a8492b0a02707ab7a3b3ff"}

[commit-bot: I haz the power, 2016-12-22 12:58:21]

Description was changed from

==========
Update TaskTraits in history_service.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
TBR=sdefresne@chromium.org
BUG=675660
==========

to

==========
Update TaskTraits in history_service.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
TBR=sdefresne@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2592133002
==========

[commit-bot: I haz the power, 2016-12-22 12:58:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 13:00:48]

Description was changed from

==========
Update TaskTraits in history_service.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
TBR=sdefresne@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2592133002
==========

to

==========
Update TaskTraits in history_service.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
TBR=sdefresne@chromium.org
BUG=675660

Committed: https://crrev.com/81a5ca8f084ec7ecada62fa3cb7788de66d3fbf4
Cr-Commit-Position: refs/heads/master@{#440394}
==========

[commit-bot: I haz the power, 2016-12-22 13:00:49]

Patchset 1 (id:??) landed as
https://crrev.com/81a5ca8f084ec7ecada62fa3cb7788de66d3fbf4
Cr-Commit-Position: refs/heads/master@{#440394}