Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2592103002: Improve separation between "SMIL times" and timestamps (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve separation between "SMIL times" and timestamps The 'elapsed' time does not need to be a SMILTime in general - it can only be non-finite in the case where the document is not active, and then the timeline should not be running/animations updated. Thread the double value further from SMILTimeContainer down into SVGSMILElement. Simplify some computations. BUG=641437, 676137 Committed: https://crrev.com/d6b6ebf86773fcafd3ce6cdc6fe7ef7d14bae91e Cr-Commit-Position: refs/heads/master@{#440171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 7 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
fs
4 years ago (2016-12-21 17:24:58 UTC) #6
pdr.
On 2016/12/21 at 17:24:58, fs wrote: > LGTM for the cleanup, but I don't see ...
4 years ago (2016-12-21 18:58:15 UTC) #7
fs
On 2016/12/21 at 18:58:15, pdr wrote: > On 2016/12/21 at 17:24:58, fs wrote: > > ...
4 years ago (2016-12-21 18:59:31 UTC) #8
pdr.
On 2016/12/21 at 18:59:31, fs wrote: > On 2016/12/21 at 18:58:15, pdr wrote: > > ...
4 years ago (2016-12-21 19:00:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592103002/1
4 years ago (2016-12-21 19:05:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 19:12:29 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-21 19:15:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6b6ebf86773fcafd3ce6cdc6fe7ef7d14bae91e
Cr-Commit-Position: refs/heads/master@{#440171}

Powered by Google App Engine
This is Rietveld 408576698