Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2592093003: TRACE_TASK_EXECUTION case for tracing_perftests. (Closed)

Created:
4 years ago by kraynov
Modified:
3 years, 10 months ago
CC:
picksi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing_perftests: add coverage to TRACE_TASK_EXECUTION. BUG=656029 Review-Url: https://codereview.chromium.org/2592093003 Cr-Commit-Position: refs/heads/master@{#446700} Committed: https://chromium.googlesource.com/chromium/src/+/4dcd14614295f37dfee188a3d198c02db751d2dc

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M components/tracing/test/trace_event_perftest.cc View 1 7 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kraynov
PTAL
4 years ago (2016-12-21 17:24:58 UTC) #2
kraynov
ping
3 years, 11 months ago (2017-01-25 10:30:27 UTC) #3
Primiano Tucci (use gerrit)
https://codereview.chromium.org/2592093003/diff/1/components/tracing/test/trace_event_perftest.cc File components/tracing/test/trace_event_perftest.cc (right): https://codereview.chromium.org/2592093003/diff/1/components/tracing/test/trace_event_perftest.cc#newcode175 components/tracing/test/trace_event_perftest.cc:175: std::unique_ptr<Thread> task_thread(new Thread("task_thread")); what is the purpose of this? ...
3 years, 11 months ago (2017-01-25 15:55:09 UTC) #4
kraynov
https://codereview.chromium.org/2592093003/diff/1/components/tracing/test/trace_event_perftest.cc File components/tracing/test/trace_event_perftest.cc (right): https://codereview.chromium.org/2592093003/diff/1/components/tracing/test/trace_event_perftest.cc#newcode175 components/tracing/test/trace_event_perftest.cc:175: std::unique_ptr<Thread> task_thread(new Thread("task_thread")); On 2017/01/25 15:55:09, Primiano Tucci wrote: ...
3 years, 10 months ago (2017-01-26 17:02:10 UTC) #5
Primiano Tucci (use gerrit)
LGTM but please expand a bit the cl title. I'd label it: tracing_perftests: add coverage ...
3 years, 10 months ago (2017-01-26 17:11:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592093003/20001
3 years, 10 months ago (2017-01-27 13:05:14 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 17:13:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4dcd14614295f37dfee188a3d198...

Powered by Google App Engine
This is Rietveld 408576698