Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2592043003: PPC/s390: [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)

Created:
4 years ago by JaideepBajwa
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [TypeFeedbackVector] Root literal arrays in function literals slots Port 93df094081f04c629c3df2e40318de90ce5e0fb9 Original Commit Message: Literal arrays and feedback vectors for a function can be garbage collected if we don't have a rooted closure for the function, which happens often. It's expensive to come back from this (recreating boilerplates and gathering feedback again), and the cost is disproportionate if the function was inlined into optimized code. To guard against losing these arrays when we need them, we'll now create literal arrays when creating the feedback vector for the outer closure, and root them strongly in that vector. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5456 LOG=N Review-Url: https://codereview.chromium.org/2592043003 Cr-Commit-Position: refs/heads/master@{#41898} Committed: https://chromium.googlesource.com/v8/v8/+/19aa7a20b0c39ea9ef81d6e021863183732f82c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -32 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 4 chunks +2 lines, -15 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 4 chunks +2 lines, -15 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
4 years ago (2016-12-21 16:10:16 UTC) #1
JoranSiu
On 2016/12/21 16:10:16, JaideepBajwa wrote: > ptal lgtm
4 years ago (2016-12-21 16:12:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592043003/1
4 years ago (2016-12-21 16:12:53 UTC) #4
commit-bot: I haz the power
4 years ago (2016-12-21 16:37:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/19aa7a20b0c39ea9ef81d6e021863183732...

Powered by Google App Engine
This is Rietveld 408576698