Align __lookupGetter__/__lookupSetter__ behavior with the spec

Align __lookupGetter__/__lookupSetter__ behavior with the spec

These methods now return undefined upon finding a data property in the
prototype chain which shadows an accessor property, and when hitting
a Proxy, call the appropriate proxy traps.

R=cbruni@chromium.org, littledan@chromium.org
BUG=v8:5130
Review-Url: https://codereview.chromium.org/2592013003
Cr-Commit-Position: refs/heads/master@{#41929}
Committed: https://chromium.googlesource.com/v8/v8/+/57e8acbbb310c11c2123052928e1668c118e8085

[adamk, 2016-12-21 18:39:01]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 18:39:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 19:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 19:04:28]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-12-22 10:28:06]

LGTM

Side-question: where would I find a test in test262 with __lookupGetter__ and
proxies? (yes too lazy to search :P)

[Dan Ehrenberg, 2016-12-22 16:16:12]

On 2016/12/22 10:28:06, Camillo Bruni wrote:
> LGTM
> 
> Side-question: where would I find a test in test262 with __lookupGetter__ and
> proxies? (yes too lazy to search :P)

Well, given the ones that we just flipped on. apparently there weren't any tests
for Proxy traps, just for the shadowing property. I filed a test262 feature
request at https://github.com/tc39/test262/issues/808 .

[Camillo Bruni, 2016-12-22 16:16:49]

On 2016/12/22 at 16:16:12, littledan wrote:
> On 2016/12/22 10:28:06, Camillo Bruni wrote:
> > LGTM
> > 
> > Side-question: where would I find a test in test262 with __lookupGetter__
and
> > proxies? (yes too lazy to search :P)
> 
> Well, given the ones that we just flipped on. apparently there weren't any
tests for Proxy traps, just for the shadowing property. I filed a test262
feature request at https://github.com/tc39/test262/issues/808 .

ok :)

[adamk, 2016-12-22 16:43:18]

https://codereview.chromium.org/2592013003/diff/1/test/test262/test262.status
File test/test262/test262.status (left):

https://codereview.chromium.org/2592013003/diff/1/test/test262/test262.status...
test/test262/test262.status:323:
'annexB/built-ins/Object/prototype/__lookupGetter__/lookup-own-get-err': [FAIL],
All the "-err" cases removed from this list test part of the Proxy path, in that
they throw when accessing the getOwnPropertyDescriptor and getPrototypeOf traps.

I can add an mjsunit test for now showing that we actually look at the return
value of these traps.

[adamk, 2016-12-22 17:18:02]

Added a test, PTAL

[adamk, 2016-12-22 17:25:05]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 17:25:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 17:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 17:54:03]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-12-22 18:57:19]

lgtm

test lgtm

[adamk, 2016-12-22 19:22:42]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-12-22 19:22:43]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2592013003/#ps20001
(title: "Add test")

[commit-bot: I haz the power, 2016-12-22 19:22:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 19:24:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482434562948050,
"parent_rev": "207214b60456a843122900fde3c8a3097f63a513", "commit_rev":
"57e8acbbb310c11c2123052928e1668c118e8085"}

[commit-bot: I haz the power, 2016-12-22 19:24:53]

Description was changed from

==========
Align __lookupGetter__/__lookupSetter__ behavior with the spec

These methods now return undefined upon finding a data property in the
prototype chain which shadows an accessor property, and when hitting
a Proxy, call the appropriate proxy traps.

R=cbruni@chromium.org, littledan@chromium.org
BUG=v8:5130
==========

to

==========
Align __lookupGetter__/__lookupSetter__ behavior with the spec

These methods now return undefined upon finding a data property in the
prototype chain which shadows an accessor property, and when hitting
a Proxy, call the appropriate proxy traps.

R=cbruni@chromium.org, littledan@chromium.org
BUG=v8:5130

Review-Url: https://codereview.chromium.org/2592013003
Cr-Commit-Position: refs/heads/master@{#41929}
Committed:
https://chromium.googlesource.com/v8/v8/+/57e8acbbb310c11c2123052928e1668c118...
==========

[commit-bot: I haz the power, 2016-12-22 19:24:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/57e8acbbb310c11c2123052928e1668c118...