Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issue 2591953002: Update SignalingAddress to normalize all JIDs. (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Update SignalingAddress to normalize all JIDs. Previously JIDs were not normalized consistently which results in failure to connect when host has mixed-case JID. This CL fixes it by making SignalingAddress always normalize all JIDs. Also it's now a class instead of struct, to ensure that the content is always consistent. BUG=675014 Review-Url: https://codereview.chromium.org/2577333003 Cr-Commit-Position: refs/heads/master@{#439623} (cherry picked from commit 428e8936ff8346722f3268db7b7d8df7117f5ad9) Committed: https://chromium.googlesource.com/chromium/src/+/ce9009479f12fa5b335f53a027a6ec8ebef69af6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -55 lines) Patch
M remoting/protocol/jingle_messages.h View 2 chunks +18 lines, -13 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 7 chunks +36 lines, -32 lines 0 comments Download
M remoting/protocol/jingle_messages_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 5 chunks +26 lines, -3 lines 0 comments Download
M remoting/signaling/fake_signal_strategy.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Sergey Ulanov
4 years ago (2016-12-21 00:15:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce9009479f12fa5b335f53a027a6ec8ebef69af6.

Powered by Google App Engine
This is Rietveld 408576698