Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2577333003: Update SignalingAddress to normalize all JIDs. (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SignalingAddress to normalize all JIDs. Previously JIDs were not normalized consistently which results in failure to connect when host has mixed-case JID. This CL fixes it by making SignalingAddress always normalize all JIDs. Also it's now a class instead of struct, to ensure that the content is always consistent. BUG=675014 Committed: https://crrev.com/428e8936ff8346722f3268db7b7d8df7117f5ad9 Cr-Commit-Position: refs/heads/master@{#439623}

Patch Set 1 : . #

Patch Set 2 : , #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -55 lines) Patch
M remoting/protocol/jingle_messages.h View 2 chunks +18 lines, -13 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 2 7 chunks +36 lines, -32 lines 0 comments Download
M remoting/protocol/jingle_messages_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 5 chunks +26 lines, -3 lines 0 comments Download
M remoting/signaling/fake_signal_strategy.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
Sergey Ulanov
4 years ago (2016-12-16 20:50:09 UTC) #3
kelvinp
lgtm
4 years ago (2016-12-19 18:13:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577333003/20001
4 years ago (2016-12-19 18:30:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/359223)
4 years ago (2016-12-19 18:44:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577333003/40001
4 years ago (2016-12-19 23:01:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577333003/60001
4 years ago (2016-12-19 23:03:50 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-19 23:53:55 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-19 23:57:47 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/428e8936ff8346722f3268db7b7d8df7117f5ad9
Cr-Commit-Position: refs/heads/master@{#439623}

Powered by Google App Engine
This is Rietveld 408576698