Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2591933002: Make run_webkit_tests random order by default for all platforms (Closed)

Created:
4 years ago by jeffcarp
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, qyearsley
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make run_webkit_tests random order by default for all platforms. BUG=671805 R=dpranke@chromium.org,qyearsley@chromium.org Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95 Cr-Commit-Position: refs/heads/master@{#441424}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unnecessary parenthesis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 2 chunks +4 lines, -17 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 7 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
jeffcarp
Here's the CL to move everything to random by default! I plan on merging this ...
4 years ago (2016-12-20 23:56:27 UTC) #1
qyearsley
Excellent, LGTM :-) https://codereview.chromium.org/2591933002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right): https://codereview.chromium.org/2591933002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#newcode332 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:332: default=("random"), Nit: No need for parentheses ...
4 years ago (2016-12-20 23:58:06 UTC) #2
jeffcarp
On 2016/12/20 at 23:58:06, qyearsley wrote: > Excellent, LGTM :-) > > https://codereview.chromium.org/2591933002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py > File ...
3 years, 11 months ago (2017-01-04 02:10:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591933002/20001
3 years, 11 months ago (2017-01-04 19:05:02 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 19:10:47 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95 Cr-Commit-Position: refs/heads/master@{#441424}
3 years, 11 months ago (2017-01-04 19:12:29 UTC) #20
qyearsley
On 2017/01/04 at 19:12:29, commit-bot wrote: > Patchset 2 (id:??) landed as https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95 > Cr-Commit-Position: ...
3 years, 11 months ago (2017-01-04 19:22:13 UTC) #21
jeffcarp
3 years, 11 months ago (2017-01-04 20:59:19 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2617563002/ by jeffcarp@chromium.org.

The reason for reverting is: fast/text/ellipsis-stroked.html started failing on
some Linux and Mac bots..

Powered by Google App Engine
This is Rietveld 408576698