|
|
DescriptionMake run_webkit_tests random order by default for all platforms.
BUG=671805
R=dpranke@chromium.org,qyearsley@chromium.org
Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95
Cr-Commit-Position: refs/heads/master@{#441424}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Remove unnecessary parenthesis #
Messages
Total messages: 22 (14 generated)
Here's the CL to move everything to random by default! I plan on merging this once Windows is stable.
Excellent, LGTM :-) https://codereview.chromium.org/2591933002/diff/1/third_party/WebKit/Tools/Sc... File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right): https://codereview.chromium.org/2591933002/diff/1/third_party/WebKit/Tools/Sc... third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:332: default=("random"), Nit: No need for parentheses here.
Description was changed from ========== Make run_webkit_tests random order by default for all platforms BUG=671805 R=dpranke@chromium.org,qyearsley@chromium.org ========== to ========== Make run_webkit_tests random order by default for all platforms. BUG=671805 R=dpranke@chromium.org,qyearsley@chromium.org ==========
The CQ bit was checked by jeffcarp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
On 2016/12/20 at 23:58:06, qyearsley wrote: > Excellent, LGTM :-) > > https://codereview.chromium.org/2591933002/diff/1/third_party/WebKit/Tools/Sc... > File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right): > > https://codereview.chromium.org/2591933002/diff/1/third_party/WebKit/Tools/Sc... > third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:332: default=("random"), > Nit: No need for parentheses here. Removed unnecessary parenthesis and also fixed some unit tests that had assumed natural order by default.
The CQ bit was checked by jeffcarp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jeffcarp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/2591933002/#ps20001 (title: "Remove unnecessary parenthesis")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483556669972050, "parent_rev": "78b554c8b269eb6a2341c1cf7fd2c0c117dc4c78", "commit_rev": "4bc51990d1cea583d9ccdd6e00ea6b572739a682"}
Message was sent while issue was closed.
Description was changed from ========== Make run_webkit_tests random order by default for all platforms. BUG=671805 R=dpranke@chromium.org,qyearsley@chromium.org ========== to ========== Make run_webkit_tests random order by default for all platforms. BUG=671805 R=dpranke@chromium.org,qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2591933002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make run_webkit_tests random order by default for all platforms. BUG=671805 R=dpranke@chromium.org,qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2591933002 ========== to ========== Make run_webkit_tests random order by default for all platforms. BUG=671805 R=dpranke@chromium.org,qyearsley@chromium.org Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95 Cr-Commit-Position: refs/heads/master@{#441424} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95 Cr-Commit-Position: refs/heads/master@{#441424}
Message was sent while issue was closed.
On 2017/01/04 at 19:12:29, commit-bot wrote: > Patchset 2 (id:??) landed as https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95 > Cr-Commit-Position: refs/heads/master@{#441424} \o/
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2617563002/ by jeffcarp@chromium.org. The reason for reverting is: fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots.. |