Convert to use testharness.js

Convert to use testharness.js

Also converted to use the new Audit. Only the bare minimum changes
were made.

BUG=675987
TEST=automatic-pull-node.html

Committed: https://crrev.com/b84b6780b2a125d782037945ffcb37f481cf4587
Cr-Commit-Position: refs/heads/master@{#440510}

[Raymond Toy, 2016-12-20 23:52:22]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-12-20 23:52:23]

PTAL (no rush).

The new output is

This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = Uncaught
TypeError: should is not a function
PASS # AUDIT TASK RUNNER STARTED. 
PASS   RealtimeAnalyserNode got pulled when connected from upstream node but not
to downstream node is true. 
PASS < [test1] All assertions passed. (total 1 assertions) 
PASS   RealtimeAnalyserNode got pulled when connected from upstream node and to
destination node is true. 
PASS < [test2] All assertions passed. (total 1 assertions) 
PASS   RealtimeAnalyserNode didn't get pulled when it should not is true. 
PASS < [test3] All assertions passed. (total 1 assertions) 
PASS # AUDIT TASK RUNNER FINISHED: 3 tasks ran successfully. 
Harness: the test ran to completion.

The phrasing of the output isn't great, but oh well.

[hongchan, 2016-12-22 17:41:07]

The indentation really bugs me out, but we can deal with that later.

lgtm

https://codereview.chromium.org/2591923002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node.html
(right):

https://codereview.chromium.org/2591923002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node.html:14:
//description("This test verifies that the AudioBasicInspectorNode based nodes
work correctly.");
A plain comment would be better since we're not using description() any more.

[Raymond Toy, 2016-12-22 17:57:58]

Now that you've reviewed and approved the basic changes, I'm more than happy to
upload a new patch that only reindents the code.

https://codereview.chromium.org/2591923002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node.html
(right):

https://codereview.chromium.org/2591923002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node.html:14:
//description("This test verifies that the AudioBasicInspectorNode based nodes
work correctly.");
On 2016/12/22 17:41:07, hongchan wrote:
> A plain comment would be better since we're not using description() any more.

Oops. I meant to remove this. But a comment is better so we know what this test
is doing.

[Raymond Toy, 2016-12-22 18:13:21]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-12-22 18:13:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2591923002/#ps40001
(title: "Reindent")

[commit-bot: I haz the power, 2016-12-22 18:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 19:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 19:13:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2016-12-22 20:29:41]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-12-22 20:29:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2591923002/#ps60001
(title: "Remove unneeded expected result")

[commit-bot: I haz the power, 2016-12-22 20:29:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 21:31:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482438581858190,
"parent_rev": "56afad6a8a1fd8bbe4af6d749287203da5e60717", "commit_rev":
"c7bb5ecff47878117e1139d92bc9ceb96b5e37cf"}

[commit-bot: I haz the power, 2016-12-22 21:32:18]

Description was changed from

==========
Convert to use testharness.js

Also converted to use the new Audit. Only the bare minimum changes
were made.

BUG=675987
TEST=automatic-pull-node.html
==========

to

==========
Convert to use testharness.js

Also converted to use the new Audit. Only the bare minimum changes
were made.

BUG=675987
TEST=automatic-pull-node.html

Review-Url: https://codereview.chromium.org/2591923002
==========

[commit-bot: I haz the power, 2016-12-22 21:32:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-22 21:34:46]

Description was changed from

==========
Convert to use testharness.js

Also converted to use the new Audit. Only the bare minimum changes
were made.

BUG=675987
TEST=automatic-pull-node.html

Review-Url: https://codereview.chromium.org/2591923002
==========

to

==========
Convert to use testharness.js

Also converted to use the new Audit. Only the bare minimum changes
were made.

BUG=675987
TEST=automatic-pull-node.html

Committed: https://crrev.com/b84b6780b2a125d782037945ffcb37f481cf4587
Cr-Commit-Position: refs/heads/master@{#440510}
==========

[commit-bot: I haz the power, 2016-12-22 21:34:47]

Patchset 4 (id:??) landed as
https://crrev.com/b84b6780b2a125d782037945ffcb37f481cf4587
Cr-Commit-Position: refs/heads/master@{#440510}