Fix use-after-free issues in UpgradeDetectorImplTest.

Fix use-after-free issues in UpgradeDetectorImplTest.

UpgradeDetectorImpl posts a task to check for unstable channel
onto FILE thread. We need to give this task to be executed before
the detector goes out of scope.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
Committed: https://crrev.com/b7bb99fe5dfd71c08bbe4dfa23a1cce39929af22
Cr-Commit-Position: refs/heads/master@{#440016}

[krasin1, 2016-12-20 23:42:25]

krasin@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-12-21 03:55:59]

lgtm

https://codereview.chromium.org/2591913002/diff/1/chrome/browser/upgrade_dete...
File chrome/browser/upgrade_detector_impl_unittest.cc (right):

https://codereview.chromium.org/2591913002/diff/1/chrome/browser/upgrade_dete...
chrome/browser/upgrade_detector_impl_unittest.cc:94: // Run pending checks.
This isn't a good comment since it just answers "what?" and repeats the next
line. Instead, answer "why?": "// Execute tasks sent to FILE thread by
|detector| referencing it while it's still in scope" or similar

https://codereview.chromium.org/2591913002/diff/1/chrome/browser/upgrade_dete...
chrome/browser/upgrade_detector_impl_unittest.cc:119:
content::RunAllPendingInMessageLoop(content::BrowserThread::FILE);
ditto

[krasin1, 2016-12-21 04:05:22]

https://codereview.chromium.org/2591913002/diff/1/chrome/browser/upgrade_dete...
File chrome/browser/upgrade_detector_impl_unittest.cc (right):

https://codereview.chromium.org/2591913002/diff/1/chrome/browser/upgrade_dete...
chrome/browser/upgrade_detector_impl_unittest.cc:94: // Run pending checks.
On 2016/12/21 03:55:59, Nico (swamped sorry) wrote:
> This isn't a good comment since it just answers "what?" and repeats the next
> line. Instead, answer "why?": "// Execute tasks sent to FILE thread by
> |detector| referencing it while it's still in scope" or similar

Good point. Done.

https://codereview.chromium.org/2591913002/diff/1/chrome/browser/upgrade_dete...
chrome/browser/upgrade_detector_impl_unittest.cc:119:
content::RunAllPendingInMessageLoop(content::BrowserThread::FILE);
On 2016/12/21 03:55:59, Nico (swamped sorry) wrote:
> ditto

Done.

[krasin1, 2016-12-21 04:05:32]

The CQ bit was checked by krasin@chromium.org

[krasin1, 2016-12-21 04:05:32]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2591913002/#ps20001
(title: "Improve comments")

[commit-bot: I haz the power, 2016-12-21 04:05:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 04:35:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482293132320510,
"parent_rev": "9c9bb09658e832d97ac49a432a845de30b149c68", "commit_rev":
"441a0ef3ebcd230a099ade2fb86bf75c9aa40deb"}

[commit-bot: I haz the power, 2016-12-21 04:36:11]

Description was changed from

==========
Fix use-after-free issues in UpgradeDetectorImplTest.

UpgradeDetectorImpl posts a task to check for unstable channel
onto FILE thread. We need to give this task to be executed before
the detector goes out of scope.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
==========

to

==========
Fix use-after-free issues in UpgradeDetectorImplTest.

UpgradeDetectorImpl posts a task to check for unstable channel
onto FILE thread. We need to give this task to be executed before
the detector goes out of scope.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897

Review-Url: https://codereview.chromium.org/2591913002
==========

[commit-bot: I haz the power, 2016-12-21 04:36:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 04:38:29]

Description was changed from

==========
Fix use-after-free issues in UpgradeDetectorImplTest.

UpgradeDetectorImpl posts a task to check for unstable channel
onto FILE thread. We need to give this task to be executed before
the detector goes out of scope.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897

Review-Url: https://codereview.chromium.org/2591913002
==========

to

==========
Fix use-after-free issues in UpgradeDetectorImplTest.

UpgradeDetectorImpl posts a task to check for unstable channel
onto FILE thread. We need to give this task to be executed before
the detector goes out of scope.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897

Committed: https://crrev.com/b7bb99fe5dfd71c08bbe4dfa23a1cce39929af22
Cr-Commit-Position: refs/heads/master@{#440016}
==========

[commit-bot: I haz the power, 2016-12-21 04:38:30]

Patchset 2 (id:??) landed as
https://crrev.com/b7bb99fe5dfd71c08bbe4dfa23a1cce39929af22
Cr-Commit-Position: refs/heads/master@{#440016}