[wasm] Use Param and Return methods consistently

[wasm] Use Param and Return methods consistently

Also, provide a variadic template Return function for easier use, and
refactor the underlying Return function to not use the Buffer, since
that might still be needed later (for example if trap code is generated
during CallIndirect, and the arguments to the call are stored in the
buffer).

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2591903003
Cr-Commit-Position: refs/heads/master@{#41888}
Committed: https://chromium.googlesource.com/v8/v8/+/0ba82511da3daea4cf1bbd4acf985e8da36d8eb1

[Clemens Hammacher, 2016-12-21 10:39:41]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 10:39:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-21 10:42:17]

This is my proposal. I admit that it complicates things inside the Return
function, but it makes it much nicer for each user.

[Clemens Hammacher, 2016-12-21 10:47:41]

On 2016/12/21 at 10:42:17, Clemens Hammacher wrote:
> This is my proposal. I admit that it complicates things inside the Return
function, but it makes it much nicer for each user.

We could also make this a class, either private to wasm-compiler, or somewhere
in base. You pass a size for static allocation, and a dynamic size immediately
in constructur. Without any resizing allowed. We would not use an std::vector
then, but malloc directly. WDYT?

[titzer, 2016-12-21 10:52:02]

On 2016/12/21 10:47:41, Clemens Hammacher wrote:
> On 2016/12/21 at 10:42:17, Clemens Hammacher wrote:
> > This is my proposal. I admit that it complicates things inside the Return
> function, but it makes it much nicer for each user.
> 
> We could also make this a class, either private to wasm-compiler, or somewhere
> in base. You pass a size for static allocation, and a dynamic size immediately
> in constructur. Without any resizing allowed. We would not use an std::vector
> then, but malloc directly. WDYT?

That seems like overkill for now :-)

lgtm

[commit-bot: I haz the power, 2016-12-21 11:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 11:06:08]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-12-21 11:54:39]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-12-21 11:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 11:56:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482321279335360, "parent_rev":
"f69f826e51a3d48d63fc5d8ea25d0d2feee0ffec", "commit_rev":
"0ba82511da3daea4cf1bbd4acf985e8da36d8eb1"}

[commit-bot: I haz the power, 2016-12-21 11:56:21]

Description was changed from

==========
[wasm] Use Param and Return methods consistently

Also, provide a variadic template Return function for easier use, and
refactor the underlying Return function to not use the Buffer, since
that might still be needed later (for example if trap code is generated
during CallIndirect, and the arguments to the call are stored in the
buffer).

R=titzer@chromium.org
==========

to

==========
[wasm] Use Param and Return methods consistently

Also, provide a variadic template Return function for easier use, and
refactor the underlying Return function to not use the Buffer, since
that might still be needed later (for example if trap code is generated
during CallIndirect, and the arguments to the call are stored in the
buffer).

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2591903003
Cr-Commit-Position: refs/heads/master@{#41888}
Committed:
https://chromium.googlesource.com/v8/v8/+/0ba82511da3daea4cf1bbd4acf985e8da36...
==========

[commit-bot: I haz the power, 2016-12-21 11:56:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0ba82511da3daea4cf1bbd4acf985e8da36...