Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: tools/gn/xcode_object.h

Issue 2591893002: [Refactor Xcode Objects] Allow extra attributes for native targets. (Closed)
Patch Set: Addressed feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/xcode_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_object.h
diff --git a/tools/gn/xcode_object.h b/tools/gn/xcode_object.h
index f56de09a7806658b2cf4c870be1fddc332e6bdd5..31f989b6d02a19a1b33721b4b9077fe16fe16a29 100644
--- a/tools/gn/xcode_object.h
+++ b/tools/gn/xcode_object.h
@@ -288,7 +288,8 @@ class PBXProject : public PBXObject {
const std::string& type,
const std::string& output_name,
const std::string& output_type,
- const std::string& shell_script);
+ const std::string& shell_script,
+ const PBXAttributes& extra_attributes = PBXAttributes());
void SetProjectDirPath(const std::string& project_dir_path);
void SetProjectRoot(const std::string& project_root);
« no previous file with comments | « no previous file | tools/gn/xcode_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698