Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: tools/gn/xcode_object.cc

Issue 2591893002: [Refactor Xcode Objects] Allow extra attributes for native targets. (Closed)
Patch Set: Addressed feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/xcode_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_object.cc
diff --git a/tools/gn/xcode_object.cc b/tools/gn/xcode_object.cc
index e97cbfdb7b1a240fb1df936ed393a2bba13adab2..c3aa804d6ab8c73848678d074df0d76a93f30c09 100644
--- a/tools/gn/xcode_object.cc
+++ b/tools/gn/xcode_object.cc
@@ -667,7 +667,8 @@ void PBXProject::AddNativeTarget(const std::string& name,
const std::string& type,
const std::string& output_name,
const std::string& output_type,
- const std::string& shell_script) {
+ const std::string& shell_script,
+ const PBXAttributes& extra_attributes) {
base::StringPiece ext = FindExtension(&output_name);
PBXFileReference* product = static_cast<PBXFileReference*>(
products_->AddChild(base::MakeUnique<PBXFileReference>(
@@ -679,7 +680,7 @@ void PBXProject::AddNativeTarget(const std::string& name,
? output_name.substr(0, ext_offset - 1)
: output_name;
- PBXAttributes attributes;
+ PBXAttributes attributes = extra_attributes;
attributes["CODE_SIGNING_REQUIRED"] = "NO";
attributes["CONFIGURATION_BUILD_DIR"] = ".";
attributes["PRODUCT_NAME"] = product_name;
« no previous file with comments | « tools/gn/xcode_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698