Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 2591863002: Fix a typo in GN documentation (Closed)

Created:
4 years ago by Petr Hosek
Modified:
4 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in GN documentation This CL fixes the typo introduced in r439541. Committed: https://crrev.com/a8936b7a13ff687bb186db70681723bf8b6bd531 Cr-Commit-Position: refs/heads/master@{#439891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/docs/reference.md View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/substitution_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Petr Hosek
4 years ago (2016-12-20 20:41:55 UTC) #3
Dirk Pranke
lgtm
4 years ago (2016-12-20 21:12:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591863002/1
4 years ago (2016-12-20 21:50:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 22:14:46 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 22:16:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8936b7a13ff687bb186db70681723bf8b6bd531
Cr-Commit-Position: refs/heads/master@{#439891}

Powered by Google App Engine
This is Rietveld 408576698