Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2591833002: headless: Load resources based on locale (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Load resources based on locale ui::ResourceBundle::InitSharedInstanceWithPakPath is only meant for test use. BUG=612904 Committed: https://crrev.com/018fd0e86e365b98ffefe6253bf3b98e3b664232 Cr-Commit-Position: refs/heads/master@{#439882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M headless/lib/headless_content_main_delegate.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Sami
4 years ago (2016-12-20 19:02:10 UTC) #3
altimin
thanks, lgtm
4 years ago (2016-12-20 19:09:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591833002/1
4 years ago (2016-12-20 19:11:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 20:54:40 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 20:56:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/018fd0e86e365b98ffefe6253bf3b98e3b664232
Cr-Commit-Position: refs/heads/master@{#439882}

Powered by Google App Engine
This is Rietveld 408576698