Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2591783002: Wait visibility changes with RunLoop. (Closed)

Created:
4 years ago by Boris Yusupov
Modified:
4 years ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait visibility changes with RunLoop. Test ChromeVisibilityObserverBrowserTest.VisibilityTest is flacky on Linux: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1) (32)/builds/36743/steps/browser_tests/logs/stdio Actually problem on showing window after browser creation but it is better to wait all async operations with RunLoop. BUG= Committed: https://crrev.com/bf74456d741ececaef52c30e8c0fae48f5bd2a3a Cr-Commit-Position: refs/heads/master@{#439822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc View 3 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Boris Yusupov
Please have a look
4 years ago (2016-12-20 14:44:14 UTC) #3
rkaplow
lgtm
4 years ago (2016-12-20 15:24:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591783002/1
4 years ago (2016-12-20 15:50:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 16:51:34 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 16:55:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf74456d741ececaef52c30e8c0fae48f5bd2a3a
Cr-Commit-Position: refs/heads/master@{#439822}

Powered by Google App Engine
This is Rietveld 408576698