third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl - Issue 2591763002: RTCPeerConnection.getStats: Remove selector argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2591763002: RTCPeerConnection.getStats: Remove selector argument. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

index de9f6a4b3357ac93893427a75f9f05d4838da2e5..bcbe5029fe30e0f75765a9954a40c51096c24f52 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

@@ -107,7 +107,7 @@ enum RTCIceConnectionState {

// non-optional) argument, and there should be a third failureCallback

// argument.

[CallWith=ScriptState, LegacyInterfaceTypeChecking] Promise<void> getStats(RTCStatsCallback successCallback, optional MediaStreamTrack? selector);

- [CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats] Promise<RTCStatsReport> getStats(optional MediaStreamTrack? selector);

+ [CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats] Promise<RTCStatsReport> getStats();

Guido Urdaneta 2016/12/20 15:38:51 nit: Add a TODO with info about the selector argum

hbos_chromium 2016/12/21 10:52:27 Done.

// https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api

// TODO(guidou): The label argument should have [TreatNullAs=EmptyString]

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »