[wasm] Implement correct 2-level namespace for imports.

[wasm] Implement correct 2-level namespace for imports.

R=clemensh@chromium.org
CC=rossberg@chromium.org
BUG=chromium:575167
Review-Url: https://codereview.chromium.org/2591753002
Cr-Commit-Position: refs/heads/master@{#41866}
Committed: https://chromium.googlesource.com/v8/v8/+/6e8338865a39dceafdfd4654f39c05fc5f760c44

[titzer, 2016-12-20 13:29:03]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 13:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 13:42:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 13:42:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[titzer, 2016-12-20 14:12:48]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 14:12:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-20 14:18:23]

lgtm

https://codereview.chromium.org/2591753002/diff/1/test/mjsunit/wasm/wasm-modu...
File test/mjsunit/wasm/wasm-module-builder.js (right):

https://codereview.chromium.org/2591753002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:182: addImport(module = "", name, type)
{
Woot? What does this default argument do?

[titzer, 2016-12-20 14:23:35]

https://codereview.chromium.org/2591753002/diff/1/test/mjsunit/wasm/wasm-modu...
File test/mjsunit/wasm/wasm-module-builder.js (right):

https://codereview.chromium.org/2591753002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:182: addImport(module = "", name, type)
{
On 2016/12/20 14:18:23, Clemens Hammacher wrote:
> Woot? What does this default argument do?

If the argument is undefined, it will be automatically converted to the default
value. It's most useful for parameters at the end of the list.

I've updated this and other methods to have a default module name of empty and
to check that the name is a string.

[commit-bot: I haz the power, 2016-12-20 14:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 14:30:02]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[titzer, 2016-12-20 14:35:42]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-12-20 14:35:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org
Link to the patchset: https://codereview.chromium.org/2591753002/#ps40001
(title: "Fix checks.")

[commit-bot: I haz the power, 2016-12-20 14:35:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 14:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 14:52:59]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[titzer, 2016-12-20 15:01:55]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 15:01:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 15:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 15:26:03]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-12-20 15:31:01]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-12-20 15:31:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org
Link to the patchset: https://codereview.chromium.org/2591753002/#ps60001
(title: "Fix debug tests")

[commit-bot: I haz the power, 2016-12-20 15:31:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 15:32:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482247861361440,
"parent_rev": "a1c917ca5872d52584d0888f123ef3228f244c32", "commit_rev":
"6e8338865a39dceafdfd4654f39c05fc5f760c44"}

[commit-bot: I haz the power, 2016-12-20 15:33:02]

Description was changed from

==========
[wasm] Implement correct 2-level namespace for imports.

R=clemensh@chromium.org
CC=rossberg@chromium.org
BUG=chromium:575167
==========

to

==========
[wasm] Implement correct 2-level namespace for imports.

R=clemensh@chromium.org
CC=rossberg@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2591753002
Cr-Commit-Position: refs/heads/master@{#41866}
Committed:
https://chromium.googlesource.com/v8/v8/+/6e8338865a39dceafdfd4654f39c05fc5f7...
==========

[commit-bot: I haz the power, 2016-12-20 15:33:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/6e8338865a39dceafdfd4654f39c05fc5f7...