Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2591733003: Fix use-after-scope issue in WebFrameTest. (Closed)

Created:
4 years ago by krasin1
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use-after-scope issue in WebFrameTest. Local variable client goes out of scope before WebViewHelper, which indirectly access client during destruction. The bug was found by AddressSanitizer with use-after-free check enabled. It's currently being rolled out into Chrome, and this CL is a part of a larger cleanup of existing failures. BUG=649897 Committed: https://crrev.com/f21d6e5f8417163e52730a30b9e85fb6cfd6f251 Cr-Commit-Position: refs/heads/master@{#439982}

Patch Set 1 #

Patch Set 2 : Fix a few more similar cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
krasin1
4 years ago (2016-12-21 00:07:04 UTC) #2
haraken
LGTM
4 years ago (2016-12-21 00:08:12 UTC) #3
krasin1
On 2016/12/21 00:08:12, haraken wrote: > LGTM Thank you!
4 years ago (2016-12-21 00:19:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591733003/1
4 years ago (2016-12-21 00:19:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591733003/20001
4 years ago (2016-12-21 00:32:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 02:21:39 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 02:23:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f21d6e5f8417163e52730a30b9e85fb6cfd6f251
Cr-Commit-Position: refs/heads/master@{#439982}

Powered by Google App Engine
This is Rietveld 408576698