Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2591723003: [Fetch API] Remove Headers.prototype.getAll() (Closed)

Created:
4 years ago by dhna
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Headers.prototype.getAll() It's no longer part of the spec (https://github.com/whatwg/fetch/commit/42464c) intent-to-deprecate-and-remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/x3YXciXQWM0 BUG=645492 Review-Url: https://codereview.chromium.org/2591723003 Cr-Commit-Position: refs/heads/master@{#468022} Committed: https://chromium.googlesource.com/chromium/src/+/73dde766a935605604b2d7cca45033f8dbd9c6fb

Patch Set 1 #

Patch Set 2 : Resolove conflict. #

Patch Set 3 : Update idl test. #

Patch Set 4 : Fix http/tests/fetch #

Patch Set 5 : Fix tests. #

Patch Set 6 : Fix expose-expected. #

Patch Set 7 : Pass virtual/stable/webexposed/global-interface-listing #

Patch Set 8 : rebase #

Patch Set 9 : Fix test. #

Patch Set 10 : Fix test #

Patch Set 11 : Fix tests #

Patch Set 12 : Fix tests #

Patch Set 13 : Fix tests #

Patch Set 14 : Update get. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -64 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Headers.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Headers.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Headers.idl View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 98 (58 generated)
dhna
yhirano@ PTAL
4 years ago (2016-12-20 14:02:17 UTC) #3
yhirano
On 2016/12/20 14:02:17, dhna wrote: > yhirano@ > PTAL This is a public API change ...
4 years ago (2016-12-20 14:08:02 UTC) #5
yhirano
On 2016/12/20 14:08:02, yhirano wrote: > On 2016/12/20 14:02:17, dhna wrote: > > yhirano@ > ...
4 years ago (2016-12-20 14:08:38 UTC) #6
dhna
On 2016/12/20 14:08:38, yhirano wrote: > On 2016/12/20 14:08:02, yhirano wrote: > > On 2016/12/20 ...
4 years ago (2016-12-20 14:46:57 UTC) #7
yhirano
On 2016/12/20 14:46:57, dhna wrote: > On 2016/12/20 14:08:38, yhirano wrote: > > On 2016/12/20 ...
4 years ago (2016-12-20 15:12:03 UTC) #8
dhna
On 2016/12/20 15:12:03, yhirano wrote: > On 2016/12/20 14:46:57, dhna wrote: > > On 2016/12/20 ...
3 years, 8 months ago (2017-03-31 05:59:16 UTC) #9
yhirano
Please add a link to the intent-to-deprecate-and-remove thread in the issue description. You need to ...
3 years, 8 months ago (2017-03-31 06:58:24 UTC) #12
dhna
On 2017/03/31 06:58:24, yhirano wrote: > Please add a link to the intent-to-deprecate-and-remove thread in ...
3 years, 8 months ago (2017-03-31 09:23:47 UTC) #16
dhna
On 2017/03/31 09:23:47, dhna wrote: > On 2017/03/31 06:58:24, yhirano wrote: > > Please add ...
3 years, 8 months ago (2017-04-03 18:29:42 UTC) #21
yhirano
On 2017/04/03 18:29:42, dhna wrote: > On 2017/03/31 09:23:47, dhna wrote: > > On 2017/03/31 ...
3 years, 8 months ago (2017-04-04 01:53:23 UTC) #27
yhirano
On 2017/04/04 01:53:23, yhirano (slow) wrote: > On 2017/04/03 18:29:42, dhna wrote: > > On ...
3 years, 8 months ago (2017-04-04 04:31:45 UTC) #28
dhna
On 2017/04/04 04:31:45, yhirano (slow) wrote: > On 2017/04/04 01:53:23, yhirano (slow) wrote: > > ...
3 years, 8 months ago (2017-04-04 04:51:40 UTC) #29
dhna
On 2017/04/04 04:51:40, dhna wrote: > On 2017/04/04 04:31:45, yhirano (slow) wrote: > > On ...
3 years, 8 months ago (2017-04-04 05:03:32 UTC) #30
dhna
On 2017/04/04 05:03:32, dhna wrote: > On 2017/04/04 04:51:40, dhna wrote: > > On 2017/04/04 ...
3 years, 8 months ago (2017-04-04 05:11:43 UTC) #33
dhna
On 2017/04/04 05:11:43, dhna wrote: > On 2017/04/04 05:03:32, dhna wrote: > > On 2017/04/04 ...
3 years, 8 months ago (2017-04-04 08:17:16 UTC) #36
yhirano
lgtm Thank you for working on this issue!
3 years, 8 months ago (2017-04-05 05:26:36 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591723003/140001
3 years, 8 months ago (2017-04-05 06:54:11 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/402817)
3 years, 8 months ago (2017-04-05 07:01:11 UTC) #45
dhna
On 2017/04/05 07:01:11, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-05 07:53:01 UTC) #47
tkent
> intent-to-deprecate-and-remove > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/x3YXciXQWM0 Your intent was for deprecate-and-remove. This CL looks to remove the ...
3 years, 8 months ago (2017-04-05 07:57:47 UTC) #48
yhirano
On 2017/04/05 07:57:47, tkent wrote: > > intent-to-deprecate-and-remove > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/x3YXciXQWM0 > > Your intent ...
3 years, 8 months ago (2017-04-05 08:07:07 UTC) #49
dhna
On 2017/04/05 08:07:07, yhirano wrote: > On 2017/04/05 07:57:47, tkent wrote: > > > intent-to-deprecate-and-remove ...
3 years, 8 months ago (2017-04-05 09:09:11 UTC) #50
tkent
On 2017/04/05 at 09:09:11, corona10 wrote: > If you are okay, Can I get some ...
3 years, 8 months ago (2017-04-05 10:06:06 UTC) #51
dhna
On 2017/04/05 10:06:06, tkent wrote: > On 2017/04/05 at 09:09:11, corona10 wrote: > > If ...
3 years, 8 months ago (2017-04-05 17:53:46 UTC) #52
tkent
> But first of the all, What I need to do is adding this deprecated ...
3 years, 8 months ago (2017-04-05 22:44:45 UTC) #53
dhna
On 2017/04/05 22:44:45, tkent wrote: > > But first of the all, What I need ...
3 years, 8 months ago (2017-04-06 01:00:08 UTC) #54
dhna
On 2017/04/06 01:00:08, dhna wrote: > On 2017/04/05 22:44:45, tkent wrote: > > > But ...
3 years, 8 months ago (2017-04-11 13:03:11 UTC) #55
tkent
On 2017/04/11 at 13:03:11, corona10 wrote: > I agree that the deprecated period is necessary ...
3 years, 8 months ago (2017-04-12 13:41:16 UTC) #56
dhna
On 2017/04/12 13:41:16, tkent wrote: > On 2017/04/11 at 13:03:11, corona10 wrote: > > I ...
3 years, 8 months ago (2017-04-12 15:30:10 UTC) #57
dhna
On 2017/04/12 15:30:10, dhna wrote: > On 2017/04/12 13:41:16, tkent wrote: > > On 2017/04/11 ...
3 years, 8 months ago (2017-04-13 15:08:25 UTC) #58
tkent
lgtm
3 years, 8 months ago (2017-04-14 03:17:11 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591723003/140001
3 years, 8 months ago (2017-04-14 03:19:18 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/247990) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 8 months ago (2017-04-14 03:22:28 UTC) #63
dhna
On 2017/04/14 03:22:28, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-14 14:15:22 UTC) #78
dhna
On 2017/04/14 14:15:22, dhna wrote: > On 2017/04/14 03:22:28, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-04-28 02:28:05 UTC) #82
timvolodine
On 2017/04/28 02:28:05, dhna wrote: > On 2017/04/14 14:15:22, dhna wrote: > > On 2017/04/14 ...
3 years, 7 months ago (2017-04-28 13:46:28 UTC) #83
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591723003/240001
3 years, 7 months ago (2017-04-28 13:49:23 UTC) #86
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/328878) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-04-28 13:52:51 UTC) #88
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591723003/280001
3 years, 7 months ago (2017-04-28 16:21:45 UTC) #95
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 16:27:53 UTC) #98
Message was sent while issue was closed.
Committed patchset #14 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/73dde766a935605604b2d7cca450...

Powered by Google App Engine
This is Rietveld 408576698