Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2591693003: testing: Run headless tests on Linux (Closed)

Created:
4 years ago by Sami
Modified:
3 years, 12 months ago
Reviewers:
Dirk Pranke, altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

testing: Run headless tests on Linux Run headless tests on regular (non-headless) builds of Linux now that headless mode can be enabled at run time. BUG=612904 Committed: https://crrev.com/2f8c758cb3e6b2b27a9f2087ed6be553e67edf9d Cr-Commit-Position: refs/heads/master@{#440178}

Patch Set 1 #

Patch Set 2 : Fix pak dependency #

Patch Set 3 : Maybe fix pak file inclusion #

Patch Set 4 : Include test data files #

Patch Set 5 : More test data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M headless/BUILD.gn View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Sami
Looks like the bot is now happy with bot headless_unittests and headless_browsertests. Adding some reviewers: ...
4 years ago (2016-12-21 12:28:32 UTC) #5
altimin
lgtm
4 years ago (2016-12-21 12:29:47 UTC) #6
Dirk Pranke
lgtm
3 years, 12 months ago (2016-12-21 18:26:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591693003/80001
3 years, 12 months ago (2016-12-21 18:27:27 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
3 years, 12 months ago (2016-12-21 19:34:30 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 19:37:47 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2f8c758cb3e6b2b27a9f2087ed6be553e67edf9d
Cr-Commit-Position: refs/heads/master@{#440178}

Powered by Google App Engine
This is Rietveld 408576698