Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2591683002: Initialize the BrowserContainerView with the right frame. (Closed)

Created:
4 years ago by jif
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize the BrowserContainerView with the right frame. When the iPad Tab Switcher creates an incognito tab for the first time, an incognito BVC is created. The Tab Switcher takes a screenshot of the new incognito tab, and animates its size from a small cell to a fullscreen tab. Before this CL, the first incognito tab was created with an incorrect size, resulting in the screenshot used in the animation being incorrect. BUG=671724 Committed: https://crrev.com/50d5ba259ac6c76e63884412fb1a214858b81654 Cr-Commit-Position: refs/heads/master@{#439792}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jif
ptal
4 years ago (2016-12-20 12:22:18 UTC) #4
marq (ping after 24h)
LGTM with nit. https://codereview.chromium.org/2591683002/diff/1/ios/chrome/browser/ui/browser_view_controller.mm File ios/chrome/browser/ui/browser_view_controller.mm (right): https://codereview.chromium.org/2591683002/diff/1/ios/chrome/browser/ui/browser_view_controller.mm#newcode1172 ios/chrome/browser/ui/browser_view_controller.mm:1172: // Duplicate .xib layout for now. ...
4 years ago (2016-12-20 12:36:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591683002/20001
4 years ago (2016-12-20 13:13:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 14:01:03 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 14:02:53 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50d5ba259ac6c76e63884412fb1a214858b81654
Cr-Commit-Position: refs/heads/master@{#439792}

Powered by Google App Engine
This is Rietveld 408576698