Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2591663003: Use double precision in SVGLengthContext::convertValueToUserUnits (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use double precision in SVGLengthContext::convertValueToUserUnits This method does a bunch of <float> * <double> operations, which tickles UBSANs float-overflow warning when the result is stored back into the float (single precision) local variable. We clamp the result to a narrow enough range already at the end (and hence won't see any effects of the overflow, at least assuming IEEE754), but might as well use a double precision local variable, since that actually seems to save a few instructions while also avoiding the overflowing conversion. BUG=675140 Committed: https://crrev.com/44dabf826136f0ddfab6f908036b68c7dce9a616 Cr-Commit-Position: refs/heads/master@{#440056}

Patch Set 1 #

Patch Set 2 : Expectations updated #

Messages

Total messages: 18 (13 generated)
fs
4 years ago (2016-12-20 18:48:22 UTC) #10
pdr.
On 2016/12/20 at 18:48:22, fs wrote: > LGTM
4 years ago (2016-12-20 23:55:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591663003/20001
4 years ago (2016-12-21 08:44:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 08:50:08 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-21 08:53:01 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44dabf826136f0ddfab6f908036b68c7dce9a616
Cr-Commit-Position: refs/heads/master@{#440056}

Powered by Google App Engine
This is Rietveld 408576698