Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2591593002: Revert of [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT (Closed)

Created:
4 years ago by jbauman
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT (patchset #2 id:20001 of https://codereview.chromium.org/2579623002/ ) Reason for revert: We have enough crash dumps for now, so reverting so this doesn't prevent the hang dumps from uploading due to rate limiting. Original issue's description: > [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT > > It's unclear what's causing this, but the current instrumentation seems > to show this ExceptionCode is the last one received before a hang. > > BUG=636158, 613701 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/1104899ce2fcb512e2df2600b455fbe1f8ffc056 > Cr-Commit-Position: refs/heads/master@{#438887} TBR=sandersd@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636158, 613701 Committed: https://crrev.com/6c303dc95a8902d55ba15b85ce0c1bf0c222c22b Cr-Commit-Position: refs/heads/master@{#439690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.cc View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbauman
Created Revert of [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT
4 years ago (2016-12-20 01:28:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591593002/1
4 years ago (2016-12-20 01:28:54 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years ago (2016-12-20 01:32:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 03:21:52 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-20 03:24:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c303dc95a8902d55ba15b85ce0c1bf0c222c22b
Cr-Commit-Position: refs/heads/master@{#439690}

Powered by Google App Engine
This is Rietveld 408576698