Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2591553002: Remove non-cros support from ash/common/system. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-cros support from ash/common/system. BUG=666773 Committed: https://crrev.com/51df1c176fce083f07c22f5b13ec79c45f44fc0e Cr-Commit-Position: refs/heads/master@{#439856}

Patch Set 1 #

Total comments: 8

Patch Set 2 : jc review + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -127 lines) Patch
M ash/common/system/date/date_default_view.cc View 5 chunks +2 lines, -9 lines 0 comments Download
M ash/common/system/date/system_info_default_view.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/common/system/date/system_info_default_view.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M ash/common/system/date/tray_date.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/common/system/date/tray_date.cc View 1 3 chunks +3 lines, -10 lines 0 comments Download
M ash/common/system/date/tray_system_info.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M ash/common/system/date/tray_system_info.cc View 1 3 chunks +3 lines, -10 lines 0 comments Download
M ash/common/system/status_area_widget.h View 1 4 chunks +4 lines, -12 lines 0 comments Download
M ash/common/system/status_area_widget.cc View 13 chunks +6 lines, -29 lines 0 comments Download
M ash/common/system/system_notifier.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M ash/common/system/tiles/tiles_default_view.cc View 5 chunks +2 lines, -9 lines 0 comments Download
M ash/common/system/tiles/tray_tiles_unittest.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M ash/common/system/user/tray_user_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/common/system/web_notification/web_notification_tray.cc View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Evan Stade
4 years ago (2016-12-19 22:32:46 UTC) #4
James Cook
LGTM with nits. Thanks for doing this. https://codereview.chromium.org/2591553002/diff/1/ash/common/system/date/tray_date.cc File ash/common/system/date/tray_date.cc (right): https://codereview.chromium.org/2591553002/diff/1/ash/common/system/date/tray_date.cc#newcode23 ash/common/system/date/tray_date.cc:23: system_clock_observer_.reset(new SystemClockObserver()); ...
4 years ago (2016-12-20 00:02:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591553002/20001
4 years ago (2016-12-20 18:19:58 UTC) #10
Evan Stade
https://codereview.chromium.org/2591553002/diff/1/ash/common/system/date/tray_date.cc File ash/common/system/date/tray_date.cc (right): https://codereview.chromium.org/2591553002/diff/1/ash/common/system/date/tray_date.cc#newcode23 ash/common/system/date/tray_date.cc:23: system_clock_observer_.reset(new SystemClockObserver()); On 2016/12/20 00:02:24, James Cook wrote: > ...
4 years ago (2016-12-20 18:25:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 18:53:12 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-20 18:57:24 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/51df1c176fce083f07c22f5b13ec79c45f44fc0e
Cr-Commit-Position: refs/heads/master@{#439856}

Powered by Google App Engine
This is Rietveld 408576698