Issue 2591473002: [Merge M56] Correctly hash the input of MatchModuleWhitelistString() in pver4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2591473002: [Merge M56] Correctly hash the input of MatchModuleWhitelistString() in pver4. (Closed)

Created:
4 years ago by Nathan Parker

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[Merge M56] Correctly hash the input of MatchModuleWhitelistString() in pver4. Also add a test. BUG=673827 Review-Url: https://codereview.chromium.org/2577963004 Cr-Commit-Position: refs/heads/master@{#438951} (cherry picked from commit b17e691af473e62bd8aa4c61b96b361234171feb) Committed: https://chromium.googlesource.com/chromium/src/+/23ba6527297603feab471f77b88bbefa934a667a

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	components/safe_browsing_db/v4_local_database_manager.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	components/safe_browsing_db/v4_local_database_manager_unittest.cc	View		2 chunks	+24 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Nathan Parker

4 years ago (2016-12-19 17:23:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
23ba6527297603feab471f77b88bbefa934a667a (tree was closed).