Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: remoting/client/gl_renderer.h

Issue 2591363002: Adding drawable to CRD andorid and iOS gl rendering pipeline. (Closed)
Patch Set: Minor cleanup of an unused const. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/gl_renderer.h
diff --git a/remoting/client/gl_renderer.h b/remoting/client/gl_renderer.h
index 832bd636667a43a2f8915bf45feed3ed8782b762..057f812665f9f27040aeee7f8cfacd6349894e05 100644
--- a/remoting/client/gl_renderer.h
+++ b/remoting/client/gl_renderer.h
@@ -6,6 +6,7 @@
#define REMOTING_CLIENT_GL_RENDERER_H_
#include <queue>
+#include <vector>
#include "base/callback.h"
#include "base/macros.h"
@@ -91,9 +92,13 @@ class GlRenderer {
// Called when the surface is destroyed.
void OnSurfaceDestroyed();
+ void AddDrawable(base::WeakPtr<GlDrawable> drawable);
+
// Returns the weak pointer to be used on the display thread.
base::WeakPtr<GlRenderer> GetWeakPtr();
+ static GlRenderer* CreateGlRendererWithDesktop();
joedow 2016/12/22 00:29:03 Add comment block please. Who owns the renderer*
joedow 2016/12/22 19:18:10 Actually this would also be more clear if it retur
nicholss 2017/01/09 18:50:24 Done.
+
private:
friend class GlRendererTest;
@@ -125,8 +130,9 @@ class GlRenderer {
GlCursorFeedback cursor_feedback_;
GlDesktop desktop_;
+ std::vector<base::WeakPtr<GlDrawable>> drawables_;
+
base::ThreadChecker thread_checker_;
- base::WeakPtr<GlRenderer> weak_ptr_;
base::WeakPtrFactory<GlRenderer> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(GlRenderer);

Powered by Google App Engine
This is Rietveld 408576698