Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2591333002: Register app and window icon properties for aura mus conversion. (Closed)

Created:
4 years ago by msw
Modified:
4 years ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register app and window icon properties for aura mus conversion. This ports aura app and window icon properties over mus. BUG=663522 TEST=chrome --mash task_viewer shelf item has an icon. R=sadrul@chromium.org TBR=tsepez@chromium.org Committed: https://crrev.com/0c069a141a3acf78acc9fa357a558bf326ba4b73 Cr-Commit-Position: refs/heads/master@{#440411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M services/ui/public/interfaces/window_manager.mojom View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/aura/mus/property_converter.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
msw
Hey Sadrul, please take a look; thanks! Hey Tom, PTAL as you have time (TBR ...
4 years ago (2016-12-21 21:31:04 UTC) #3
Tom Sepez
lgtm
4 years ago (2016-12-21 22:49:07 UTC) #6
sadrul
Is it possible to write tests for these? lgtm
4 years ago (2016-12-22 00:35:44 UTC) #9
msw
On 2016/12/22 00:35:44, sadrul wrote: > Is it possible to write tests for these? lgtm ...
4 years ago (2016-12-22 14:19:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591333002/1
4 years ago (2016-12-22 14:19:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 14:23:59 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-22 14:25:41 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c069a141a3acf78acc9fa357a558bf326ba4b73
Cr-Commit-Position: refs/heads/master@{#440411}

Powered by Google App Engine
This is Rietveld 408576698