Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2591273002: [layoutng] Better abspos support in legacy interop (Closed)

Created:
4 years ago by cbiesinger
Modified:
3 years, 11 months ago
Reviewers:
atotic, ikilpatrick
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Better abspos support in legacy interop In legacy layout, abspos differs from regular blocks in that abspos blocks position themselves in their own layout, instead of getting positioned by their parent. So it we are a positioned block in a legacy-layout containing block, we have to emulate this positioning, which is what this change does. Fixes this testcase: <div style="height: 200px; background: yellow; position: relative;"> XXX <div style="position: absolute; bottom: 0;"> <div>Bottom</div> </div> </div> R=atotic@chromium.org,ikilpatrick@chromium.org BUG=635619 Committed: https://crrev.com/b235a3a7becc58e7f82760c5ee5da04f767ecbd8 Cr-Commit-Position: refs/heads/master@{#440975}

Patch Set 1 #

Patch Set 2 : better code & comment #

Patch Set 3 : isPositioned -> isOutOfFlowPositioned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
cbiesinger
4 years ago (2016-12-21 18:47:42 UTC) #1
atotic
lgtm
3 years, 11 months ago (2016-12-29 17:49:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591273002/40001
3 years, 11 months ago (2016-12-29 17:49:15 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-12-29 19:04:10 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:52 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b235a3a7becc58e7f82760c5ee5da04f767ecbd8
Cr-Commit-Position: refs/heads/master@{#440975}

Powered by Google App Engine
This is Rietveld 408576698