Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2591243002: FrameView: Don't try to update the throttling status of a deleted frame (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FrameView: Don't try to update the throttling status of a deleted frame Because of the way the implicit |this| argument of a lambda and WTF::bind() interact, we need to explicitly check if the given FrameView was deleted before updating its throttling status. BUG=673070 Committed: https://crrev.com/59e1644eb56dfa290da4ef5a6173a00484404904 Cr-Commit-Position: refs/heads/master@{#440161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Sami
4 years ago (2016-12-21 15:57:17 UTC) #5
dcheng
LGTM
4 years ago (2016-12-21 17:22:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591243002/1
4 years ago (2016-12-21 18:28:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 18:35:47 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 18:37:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59e1644eb56dfa290da4ef5a6173a00484404904
Cr-Commit-Position: refs/heads/master@{#440161}

Powered by Google App Engine
This is Rietveld 408576698