Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 25912003: cc: Stop using magic numbers to detect if we can use partial updates. (Closed)

Created:
7 years, 2 months ago by danakj
Modified:
7 years, 2 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org, atreat
Visibility:
Public.

Description

cc: Stop using magic numbers to detect if we can use partial updates. We were using size_t's max value to detect if we can always use partial updates, but this is pretty magical. Instead, enable it when 1) The renderer allows partial updates at all (not ubercomp), and 2) Using single thread proxy. R=reveman@chromium.org BUG=234233 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -23 lines) Patch
M cc/layers/tiled_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +39 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
7 years, 2 months ago (2013-10-03 18:47:26 UTC) #1
reveman
lgtm
7 years, 2 months ago (2013-10-03 19:34:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/25912003/1
7 years, 2 months ago (2013-10-03 19:39:37 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 01:27:53 UTC) #4
Message was sent while issue was closed.
Change committed as 226924

Powered by Google App Engine
This is Rietveld 408576698