Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2591193002:
[promises] Simplify PromiseSetHasHandler (Closed)
Description[promises] Simplify PromiseSetHasHandler
No need to untag/tag flags, and we can also omit the write barrier.
BUG=v8:5343
Review-Url: https://codereview.chromium.org/2591193002
Cr-Commit-Position: refs/heads/master@{#41890}
Committed: https://chromium.googlesource.com/v8/v8/+/bc981e61dec5aee21a98d80ec095bc03aea2349a
Patch Set 1 #
Total comments: 2
Patch Set 2 : WordOr -> SmiOr #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + gsathya@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18274) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18184)
ishell@chromium.org changed reviewers: + ishell@chromium.org
lgtm with correction: https://codereview.chromium.org/2591193002/diff/1/src/builtins/builtins-promi... File src/builtins/builtins-promise.cc (right): https://codereview.chromium.org/2591193002/diff/1/src/builtins/builtins-promi... src/builtins/builtins-promise.cc:99: WordOr(flags, SmiConstant(1 << JSPromise::kHasHandlerBit)); s/WordOr/SmiOr/
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2591193002/diff/1/src/builtins/builtins-promi... File src/builtins/builtins-promise.cc (right): https://codereview.chromium.org/2591193002/diff/1/src/builtins/builtins-promi... src/builtins/builtins-promise.cc:99: WordOr(flags, SmiConstant(1 << JSPromise::kHasHandlerBit)); On 2016/12/21 11:20:04, Igor Sheludko wrote: > s/WordOr/SmiOr/ Done.
The CQ bit was unchecked by jgruber@chromium.org
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org Link to the patchset: https://codereview.chromium.org/2591193002/#ps20001 (title: "WordOr -> SmiOr")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482327022496410,
"parent_rev": "ceb29f7c62d3e5e19fa8ba54b543fed71e944112", "commit_rev":
"bc981e61dec5aee21a98d80ec095bc03aea2349a"}
Message was sent while issue was closed.
Description was changed from ========== [promises] Simplify PromiseSetHasHandler No need to untag/tag flags, and we can also omit the write barrier. BUG=v8:5343 ========== to ========== [promises] Simplify PromiseSetHasHandler No need to untag/tag flags, and we can also omit the write barrier. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2591193002 Cr-Commit-Position: refs/heads/master@{#41890} Committed: https://chromium.googlesource.com/v8/v8/+/bc981e61dec5aee21a98d80ec095bc03aea... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/bc981e61dec5aee21a98d80ec095bc03aea... |
