Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2591123003: fix mojom bindings generator exception error message (Closed)

Created:
4 years ago by Mostyn Bramley-Moore
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix mojom bindings generator exception error message Followup to https://codereview.chromium.org/2171033002 Committed: https://crrev.com/5a03720f53e734a17fbc9d2b8adb8cb78fbd5bdf Cr-Commit-Position: refs/heads/master@{#440142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/bindings/mojom_bindings_generator.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Mostyn Bramley-Moore
@yzshen1, Luis: please take a look at this small fixup to https://codereview.chromium.org/2171033002
4 years ago (2016-12-21 11:28:57 UTC) #4
Luis Héctor Chávez
oops, thank you for fixing that! lgtm
4 years ago (2016-12-21 16:39:22 UTC) #8
yzshen1
Thanks! LGTM
4 years ago (2016-12-21 17:02:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591123003/1
4 years ago (2016-12-21 17:38:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 17:45:48 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-21 17:48:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a03720f53e734a17fbc9d2b8adb8cb78fbd5bdf
Cr-Commit-Position: refs/heads/master@{#440142}

Powered by Google App Engine
This is Rietveld 408576698