Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2591103003: [intl] Remove dead code to support v8Parse method (Closed)

Created:
4 years ago by Dan Ehrenberg
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intl] Remove dead code to support v8Parse method The methods Intl.NumberFormat.prototype.v8Parse and Intl.DateTimeFormat.prototype.v8Parse were removed several months ago due to low usage and lack of standardization potential. This patch removes some runtime functions used to implement them, which were accidentally left in when they were taken out. BUG=v8:3785 Review-Url: https://codereview.chromium.org/2591103003 Cr-Commit-Position: refs/heads/master@{#41887} Committed: https://chromium.googlesource.com/v8/v8/+/f69f826e51a3d48d63fc5d8ea25d0d2feee0ffec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -67 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 2 chunks +0 lines, -65 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Ehrenberg
4 years ago (2016-12-21 10:00:21 UTC) #6
Yang
On 2016/12/21 10:00:21, Dan Ehrenberg wrote: all red CLs always lgtm :)
4 years ago (2016-12-21 11:36:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591103003/1
4 years ago (2016-12-21 11:44:11 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-21 11:46:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f69f826e51a3d48d63fc5d8ea25d0d2feee...

Powered by Google App Engine
This is Rietveld 408576698