Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2591073002:
Simplify context menu for misspelled words + add metrics to this context (Closed)
|
Created:
4 years ago by edwardjung Modified:
3 years, 4 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSimplify context menu for misspelled words
+ Add metrics for misspelled word context to measure usage of menu items.
BUG=678655
Review-Url: https://codereview.chromium.org/2591073002
Cr-Commit-Position: refs/heads/master@{#442545}
Committed: https://chromium.googlesource.com/chromium/src/+/8bedca0b30c55f439af1f13f580dcfb352856d8b
Patch Set 1 #Patch Set 2 : Add histogram for misspelled word context menu #Patch Set 3 : Update browser tests #Patch Set 4 : Merge #
Total comments: 2
Messages
Total messages: 36 (28 generated)
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Simplify context menu for misspelled words BUG= ========== to ========== Simplify context menu for misspelled words + Add metrics for misspelled word context to measure usage of menu items. BUG=678655 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
edwardjung@chromium.org changed reviewers: + avi@chromium.org
@avi PTAL at: c/b/renderer_context_menu/render_view_context_menu.cc c/b/renderer_context_menu/spelling_menu_observer.cc c/b/renderer_context_menu/spelling_menu_observer_browsertest.cc @holte PTAL at: tools/metrics/histograms/histograms.xml Thanks
lgtm
edwardjung@chromium.org changed reviewers: + holte@chromium.org
@holte PTAL at: tools/metrics/histograms/histograms.xml
lgtm
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by edwardjung@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2591073002/#ps60001 (title: "Merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484042814716950,
"parent_rev": "d38026c5a4b7a69552a4d7f41c37fdb735f0e283", "commit_rev":
"8bedca0b30c55f439af1f13f580dcfb352856d8b"}
Message was sent while issue was closed.
Description was changed from ========== Simplify context menu for misspelled words + Add metrics for misspelled word context to measure usage of menu items. BUG=678655 ========== to ========== Simplify context menu for misspelled words + Add metrics for misspelled word context to measure usage of menu items. BUG=678655 Review-Url: https://codereview.chromium.org/2591073002 Cr-Commit-Position: refs/heads/master@{#442545} Committed: https://chromium.googlesource.com/chromium/src/+/8bedca0b30c55f439af1f13f580d... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/8bedca0b30c55f439af1f13f580d...
Message was sent while issue was closed.
thestig@chromium.org changed reviewers: + thestig@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2591073002/diff/60001/chrome/browser/renderer... File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/2591073002/diff/60001/chrome/browser/renderer... chrome/browser/renderer_context_menu/render_view_context_menu.cc:1295: params_.misspelled_word.empty()) { Why does printing care if there's misspelled words or not?
Message was sent while issue was closed.
https://codereview.chromium.org/2591073002/diff/60001/chrome/browser/renderer... File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/2591073002/diff/60001/chrome/browser/renderer... chrome/browser/renderer_context_menu/render_view_context_menu.cc:1295: params_.misspelled_word.empty()) { On 2017/08/02 01:37:17, Lei Zhang wrote: > Why does printing care if there's misspelled words or not? We're trying to optimise the context menu so that we don't have items like print on context menu click on a misspelled word. It's highly unlikely you don't want to print a misspelled word. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
