Convert audiobuffersource-ended to testharness

Convert audiobuffersource-ended to testharness

Manually convert test to use testharness.

BUG=676394
TEST=audiobuffersource-ended.html

Review-Url: https://codereview.chromium.org/2591043005
Cr-Commit-Position: refs/heads/master@{#442681}
Committed: https://chromium.googlesource.com/chromium/src/+/f38dd70ecdbd4fb194a1165cf8b8b5b08034ce20

[Raymond Toy, 2017-01-04 19:16:03]

Description was changed from

==========
Convert AudioBufferSource tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-ended.html
==========

to

==========
Convert audiobuffersource-ended to testharness

Manually convert test to use testharness.

BUG=676394
TEST=audiobuffersource-ended.html
==========

[Raymond Toy, 2017-01-04 19:24:50]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:25:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2017-01-04 19:26:02]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-04 19:26:03]

PTAL

[commit-bot: I haz the power, 2017-01-04 20:31:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:31:42]

Dry run: This issue passed the CQ dry run.

[hongchan, 2017-01-04 21:42:41]

lgtm

https://codereview.chromium.org/2591043005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html
(right):

https://codereview.chromium.org/2591043005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html:29:
context.startRendering();
Q: should we change this to the promise pattern?

[Raymond Toy, 2017-01-04 21:46:16]

https://codereview.chromium.org/2591043005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html
(right):

https://codereview.chromium.org/2591043005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html:29:
context.startRendering();
On 2017/01/04 21:42:41, hongchan wrote:
> Q: should we change this to the promise pattern?

Sorry, I don't follow.  The test is that the onended event fired, so I'm not
sure how the promise pattern would work here.

[hongchan, 2017-01-10 19:22:58]

lgtm

https://codereview.chromium.org/2591043005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html
(right):

https://codereview.chromium.org/2591043005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html:29:
context.startRendering();
On 2017/01/04 21:46:16, Raymond Toy wrote:
> On 2017/01/04 21:42:41, hongchan wrote:
> > Q: should we change this to the promise pattern?
> 
> Sorry, I don't follow.  The test is that the onended event fired, so I'm not
> sure how the promise pattern would work here.

Ha, I missed that. Sorry.

[Raymond Toy, 2017-01-10 19:23:55]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-10 19:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 20:50:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484076235377110,
"parent_rev": "d9689efb8f5509310872a90a9654b9592cba2d19", "commit_rev":
"f38dd70ecdbd4fb194a1165cf8b8b5b08034ce20"}

[commit-bot: I haz the power, 2017-01-10 20:51:01]

Description was changed from

==========
Convert audiobuffersource-ended to testharness

Manually convert test to use testharness.

BUG=676394
TEST=audiobuffersource-ended.html
==========

to

==========
Convert audiobuffersource-ended to testharness

Manually convert test to use testharness.

BUG=676394
TEST=audiobuffersource-ended.html

Review-Url: https://codereview.chromium.org/2591043005
Cr-Commit-Position: refs/heads/master@{#442681}
Committed:
https://chromium.googlesource.com/chromium/src/+/f38dd70ecdbd4fb194a1165cf8b8...
==========

[commit-bot: I haz the power, 2017-01-10 20:51:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f38dd70ecdbd4fb194a1165cf8b8...