Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2591043004: Replace DOMWindowProperty in modules/plugins/ with ContextClient (Closed)

Created:
3 years, 12 months ago by haraken
Modified:
3 years, 12 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DOMWindowProperty in modules/plugins/ with ContextClient We're deprecating DOMWindowProperty. BUG=610176 Committed: https://crrev.com/650b4c601daf29284da75c53557e270c552185e4 Cr-Commit-Position: refs/heads/master@{#440082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M third_party/WebKit/Source/modules/plugins/DOMMimeType.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPlugin.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPluginArray.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
3 years, 12 months ago (2016-12-21 09:35:17 UTC) #2
sof
lgtm
3 years, 12 months ago (2016-12-21 09:42:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591043004/1
3 years, 12 months ago (2016-12-21 11:52:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-21 13:34:19 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 13:35:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/650b4c601daf29284da75c53557e270c552185e4
Cr-Commit-Position: refs/heads/master@{#440082}

Powered by Google App Engine
This is Rietveld 408576698