Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2591043002:
SyzyASAN: Block for crash handler startup as temporary workaround for startup hang (Closed)
DescriptionSyzyASAN: Block for crash handler startup as temporary workaround for startup hang
TBR=grt@chromium.org
BUG=675710
Committed: https://crrev.com/ddce5b16a68a6244dc5f7df0151db34f2d0bc6e6
Cr-Commit-Position: refs/heads/master@{#439920}
Patch Set 1 #
Total comments: 2
Patch Set 2 : . #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
siggi@chromium.org changed reviewers: + chrisha@chromium.org, siggi@chromium.org
lgtm to tide us over till next year. I hate the way we litter code all over the place with literal strings naming elf's exports. Why can't we link to those? https://codereview.chromium.org/2591043002/diff/1/chrome/app/chrome_exe_main_... File chrome/app/chrome_exe_main_win.cc (right): https://codereview.chromium.org/2591043002/diff/1/chrome/app/chrome_exe_main_... chrome/app/chrome_exe_main_win.cc:213: HMODULE chrome_elf = GetModuleHandle(chrome::kChromeElfDllName); Stoopid question: why don't we simply link against chrome_elf's exports?
https://codereview.chromium.org/2591043002/diff/1/chrome/app/chrome_exe_main_... File chrome/app/chrome_exe_main_win.cc (right): https://codereview.chromium.org/2591043002/diff/1/chrome/app/chrome_exe_main_... chrome/app/chrome_exe_main_win.cc:213: HMODULE chrome_elf = GetModuleHandle(chrome::kChromeElfDllName); On 2016/12/20 20:42:47, Sigurður Ásgeirsson wrote: > Stoopid question: why don't we simply link against chrome_elf's exports? Yuck, I have no idea. We probably do here actually. I think in other places it's because the code runs in e.g. browser_tests which doesn't load chrome_elf.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ditto lgtm
Description was changed from ========== SyzyASAN: Block for crash handler startup as temporary workaround for startup hang BUG=675710 ========== to ========== SyzyASAN: Block for crash handler startup as temporary workaround for startup hang TBR=grt@chromium.org BUG=675710 ==========
scottmg@chromium.org changed reviewers: + grt@chromium.org
I updated it to call directly, and I did a is_syzyasan build and it seems OK. I'm going to TBR grt for chrome/app owners as I'm out after today. If anyone is around, feel encouraged to revert if it made anything worse.
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org, chrisha@chromium.org Link to the patchset: https://codereview.chromium.org/2591043002/#ps20001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482271751427840,
"parent_rev": "ba2274f2ba642fb1a826dbfee20904abc6455eaf", "commit_rev":
"76ac173c1ab98db8c70cae45131e6167698240c9"}
Message was sent while issue was closed.
Description was changed from ========== SyzyASAN: Block for crash handler startup as temporary workaround for startup hang TBR=grt@chromium.org BUG=675710 ========== to ========== SyzyASAN: Block for crash handler startup as temporary workaround for startup hang TBR=grt@chromium.org BUG=675710 Review-Url: https://codereview.chromium.org/2591043002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== SyzyASAN: Block for crash handler startup as temporary workaround for startup hang TBR=grt@chromium.org BUG=675710 Review-Url: https://codereview.chromium.org/2591043002 ========== to ========== SyzyASAN: Block for crash handler startup as temporary workaround for startup hang TBR=grt@chromium.org BUG=675710 Committed: https://crrev.com/ddce5b16a68a6244dc5f7df0151db34f2d0bc6e6 Cr-Commit-Position: refs/heads/master@{#439920} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ddce5b16a68a6244dc5f7df0151db34f2d0bc6e6 Cr-Commit-Position: refs/heads/master@{#439920} |
