Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 259103003: Revert 266616 "Move DefaultActivationClient to wm/core" (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 266616 "Move DefaultActivationClient to wm/core" > Move DefaultActivationClient to wm/core > > Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed. > > R=sky@chromium.org > http://crbug.com/308710 > > Review URL: https://codereview.chromium.org/250113002 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -264 lines) Patch
M trunk/src/chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/base/browser_with_test_window_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/base/view_event_test_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/content/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/content/public/test/test_renderer_host.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/content/shell/browser/shell_platform_data_aura.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/content/shell/browser/shell_platform_data_aura.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/mojo/examples/launcher/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/mojo/examples/launcher/launcher.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/mojo/mojo_examples.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/aura/aura.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + trunk/src/ui/aura/client/default_activation_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ui/aura/client/default_activation_client.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ui/aura/test/aura_test_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/test/aura_test_helper.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/ui/keyboard/keyboard.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/keyboard/keyboard_controller_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/ui/snapshot/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/snapshot/snapshot.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/snapshot/snapshot_aura_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/ui/views/test/views_test_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D trunk/src/ui/wm/core/default_activation_client.h View 1 chunk +0 lines, -73 lines 0 comments Download
D trunk/src/ui/wm/core/default_activation_client.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M trunk/src/ui/wm/test/wm_test_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/ui/wm/test/wm_test_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/ui/wm/wm.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
6 years, 7 months ago (2014-04-28 19:46:00 UTC) #1
Ben Goodger (Google)
6 years, 7 months ago (2014-04-28 19:46:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r266632 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698