Move DefaultActivationClient to wm/core

Move DefaultActivationClient to wm/core

Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.

R=sky@chromium.org
http://crbug.com/308710

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267065

[sky, 2014-04-23 20:50:11]

LGTM

https://codereview.chromium.org/250113002/diff/20001/ui/wm/core/default_activ...
File ui/wm/core/default_activation_client.cc (right):

https://codereview.chromium.org/250113002/diff/20001/ui/wm/core/default_activ...
ui/wm/core/default_activation_client.cc:25: // Overridden from WindowObserver:
nit: add virtual private destructor to make it clear this object owns its
lifetime.

[Ben Goodger (Google), 2014-04-25 22:15:27]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:28:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ben@chromium.org/250113002/130001

[commit-bot: I haz the power, 2014-04-25 22:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:28:52]

Failed to apply patch for chrome/test/base/view_event_test_base.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/test/base/view_event_test_base.cc
  Hunk #1 FAILED at 32.
  Hunk #2 succeeded at 140 (offset -7 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/test/base/view_event_test_base.cc.rej

Patch:       chrome/test/base/view_event_test_base.cc
Index: chrome/test/base/view_event_test_base.cc
diff --git a/chrome/test/base/view_event_test_base.cc
b/chrome/test/base/view_event_test_base.cc
index
d8604c94b4b55f2b9b8743345bd12d2088c152ab..7460c000a614a3f19019aa5a7c976bb775cf25f9
100644
--- a/chrome/test/base/view_event_test_base.cc
+++ b/chrome/test/base/view_event_test_base.cc
@@ -32,6 +32,7 @@
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/compositor/test/context_factories_for_test.h"
+#include "ui/wm/core/default_activation_client.h"
 #include "ui/wm/core/wm_state.h"
 #endif
 
@@ -147,6 +148,7 @@ void ViewEventTestBase::SetUp() {
   aura_test_helper_.reset(
       new aura::test::AuraTestHelper(base::MessageLoopForUI::current()));
   aura_test_helper_->SetUp();
+  new wm::DefaultActivationClient(aura_test_helper_->root_window());
   context = aura_test_helper_->root_window();
 #endif  // !USE_ASH && USE_AURA

[Ben Goodger (Google), 2014-04-28 19:07:43]

Committed patchset #9 manually as r266616 (presubmit successful).

[Ben Goodger (Google), 2014-04-29 20:29:45]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2014-04-29 20:41:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ben@chromium.org/250113002/170001

[Ben Goodger (Google), 2014-04-29 22:17:04]

Committed patchset #10 manually as r266975 (presubmit successful).

[robliao, 2014-04-30 00:09:22]

A revert of this CL has been created in
https://codereview.chromium.org/261553002/ by robliao@chromium.org.

The reason for reverting is: views_unittest TooltipController test failures
views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
stdio
Capture
CloseOnCaptureLost
DontShowEmptyTooltips
EnableOrDisableTooltips
HideOnExit
ReshowOnClickAfterEnterExit
TooltipHidesOnKeyPressAndStaysHiddenUntilChange
TooltipHidesOnTimeoutAndStaysHiddenUntilChange
TooltipsInMultipleViews
ViewTooltip


TooltipControllerTest.ViewTooltip (run #2):
[ RUN      ] TooltipControllerTest.ViewTooltip
Xlib:  extension "RANDR" missing on display ":9".
Received signal 11 SEGV_MAPERR 000000000000
#0 0x000000a88e4e base::debug::StackTrace::StackTrace()
#1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f9474270cb0 \u003Cunknown>
#3 0x000000736b83 views::NativeWidgetAura::Activate()
#4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
#5 0x000000738acb views::Widget::Show()
#6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
#7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
#8 0x00000065a16a testing::Test::Run()..

[Ben Goodger (Google), 2014-04-30 03:30:05]

On 2014/04/30 00:09:22, robliao wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/261553002/ by mailto:robliao@chromium.org.
> 
> The reason for reverting is: views_unittest TooltipController test failures
> views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
> stdio
> Capture
> CloseOnCaptureLost
> DontShowEmptyTooltips
> EnableOrDisableTooltips
> HideOnExit
> ReshowOnClickAfterEnterExit
> TooltipHidesOnKeyPressAndStaysHiddenUntilChange
> TooltipHidesOnTimeoutAndStaysHiddenUntilChange
> TooltipsInMultipleViews
> ViewTooltip
> 
> 
> TooltipControllerTest.ViewTooltip (run #2):
> [ RUN      ] TooltipControllerTest.ViewTooltip
> Xlib:  extension "RANDR" missing on display ":9".
> Received signal 11 SEGV_MAPERR 000000000000
> #0 0x000000a88e4e base::debug::StackTrace::StackTrace()
> #1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler()
> #2 0x7f9474270cb0 \u003Cunknown>
> #3 0x000000736b83 views::NativeWidgetAura::Activate()
> #4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
> #5 0x000000738acb views::Widget::Show()
> #6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
> #7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
> #8 0x00000065a16a testing::Test::Run()..

Can you link me to the failure I can't see anything on build.chromium.org?

[Ben Goodger (Google), 2014-04-30 03:31:10]

On 2014/04/30 03:30:05, Ben Goodger (Google) wrote:
> On 2014/04/30 00:09:22, robliao wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/261553002/ by mailto:robliao@chromium.org.
> > 
> > The reason for reverting is: views_unittest TooltipController test failures
> > views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
> > stdio
> > Capture
> > CloseOnCaptureLost
> > DontShowEmptyTooltips
> > EnableOrDisableTooltips
> > HideOnExit
> > ReshowOnClickAfterEnterExit
> > TooltipHidesOnKeyPressAndStaysHiddenUntilChange
> > TooltipHidesOnTimeoutAndStaysHiddenUntilChange
> > TooltipsInMultipleViews
> > ViewTooltip
> > 
> > 
> > TooltipControllerTest.ViewTooltip (run #2):
> > [ RUN      ] TooltipControllerTest.ViewTooltip
> > Xlib:  extension "RANDR" missing on display ":9".
> > Received signal 11 SEGV_MAPERR 000000000000
> > #0 0x000000a88e4e base::debug::StackTrace::StackTrace()
> > #1 0x000000a89068 base::debug::(anonymous
namespace)::StackDumpSignalHandler()
> > #2 0x7f9474270cb0 \u003Cunknown>
> > #3 0x000000736b83 views::NativeWidgetAura::Activate()
> > #4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
> > #5 0x000000738acb views::Widget::Show()
> > #6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
> > #7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
> > #8 0x00000065a16a testing::Test::Run()..
> 
> Can you link me to the failure I can't see anything on build.chromium.org?

I see, nevermind.

[Ben Goodger (Google), 2014-04-30 04:48:28]

Committed patchset #11 manually as r267065 (presubmit successful).